With MergeValues() removed, amend DebugLocEntry's constructor so that it
takes multiple values rather than a single, and keep non-fragment values
in OpenRanges, as this allows some cleanup of the code in
buildLocationList().
Details
Details
Diff Detail
Diff Detail
Event Timeline
lib/CodeGen/AsmPrinter/DebugLocEntry.h | ||
---|---|---|
131–134 | This'll get flagged as an unused variable (-Wunused) in a no-asserts build, so best to roll it back into the assertion. |
Comment Actions
Move lambda expression back into assert() to avoid -Wunused-variable warning in non-assert builds.
llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h | ||
---|---|---|
103 ↗ | (On Diff #190522) | Since you modified this, you are probably in a good position to add a doxygen comment explaining what the individual parameters mean? Alternatively renaming B to Begin might also suffice. |
llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h | ||
---|---|---|
103 ↗ | (On Diff #190522) | I renamed the variables and added a Doxygen comment to clarify that End is excluded from the range, and that Vals can't be empty. |
This'll get flagged as an unused variable (-Wunused) in a no-asserts build, so best to roll it back into the assertion.