Page MenuHomePhabricator

[DebugInfo] Remove redundant DebugLocEntry::MergeValues() function, NFC

Authored by dstenb on Mar 13 2019, 9:07 AM.



The MergeValues() function would try to merge two entries if they shared
the same beginning label. Having the same beginning label means that the
former entry's range would be empty; however, after D55919 we no longer
create entries for empty ranges, so we can no longer land in a situation
where that check in MergeValues would succeed. Instead, the "merging" is
done by keeping the live values from the preceding empty ranges in
OpenRanges, and adding them to the first non-empty range.

Diff Detail


Event Timeline

dstenb created this revision.Mar 13 2019, 9:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2019, 9:07 AM
aprantl accepted this revision.Apr 8 2019, 11:33 AM
This revision is now accepted and ready to land.Apr 8 2019, 11:33 AM
This revision was automatically updated to reflect the committed changes.