Page MenuHomePhabricator

[DebugInfo] Pass all values in DebugLocEntry's constructor, NFC
ClosedPublic

Authored by dstenb on Mar 13 2019, 9:10 AM.

Details

Summary

With MergeValues() removed, amend DebugLocEntry's constructor so that it
takes multiple values rather than a single, and keep non-fragment values
in OpenRanges, as this allows some cleanup of the code in
buildLocationList().

Diff Detail

Repository
rL LLVM

Event Timeline

dstenb created this revision.Mar 13 2019, 9:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2019, 9:10 AM
dblaikie added inline comments.Mar 13 2019, 11:38 AM
lib/CodeGen/AsmPrinter/DebugLocEntry.h
127 ↗(On Diff #190427)

This'll get flagged as an unused variable (-Wunused) in a no-asserts build, so best to roll it back into the assertion.

dstenb updated this revision to Diff 190522.Mar 13 2019, 3:40 PM

Move lambda expression back into assert() to avoid -Wunused-variable warning in non-assert builds.

dstenb marked an inline comment as done.Mar 13 2019, 3:41 PM
aprantl accepted this revision.Mon, Apr 8, 11:32 AM
aprantl added inline comments.
llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h
103 ↗(On Diff #190522)

Since you modified this, you are probably in a good position to add a doxygen comment explaining what the individual parameters mean? Alternatively renaming B to Begin might also suffice.

This revision is now accepted and ready to land.Mon, Apr 8, 11:32 AM
dstenb updated this revision to Diff 194279.Tue, Apr 9, 2:57 AM
dstenb marked an inline comment as done.

Rebase, and add Doxygen comment.

dstenb added inline comments.Tue, Apr 9, 2:59 AM
llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h
103 ↗(On Diff #190522)

I renamed the variables and added a Doxygen comment to clarify that End is excluded from the range, and that Vals can't be empty.

This revision was automatically updated to reflect the committed changes.