Page MenuHomePhabricator

Moving ManagedMemoryRewritePass when hybrid option is selected
ClosedPublic

Authored by chelini on Mar 12 2019, 9:25 AM.

Details

Summary

Compiling with polly-target=hybrid was causing Polly to occur two times in the pipeline. The reason was how the ManagedMemoryRewritePass was registered in the pass manager. Being ManagedMemoryRewritePass a Modulepass was forcing all previous passes to get recomputed. This commit avoids Polly to appear two times in the pipeline registering the ManagedMemoryRewritePass later in the pass manager.

Diff Detail

Repository
rL LLVM

Event Timeline

chelini created this revision.Mar 12 2019, 9:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2019, 9:25 AM
This revision is now accepted and ready to land.Mar 12 2019, 9:56 AM

Do you need help with landing the patch?

Do you need help with landing the patch?

Hi Michael,
Yes, could you please land it on my behalf?
Thanks.

This revision was automatically updated to reflect the committed changes.

Done. Thanks for the patch!