Page MenuHomePhabricator

[NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S);`
ClosedPublic

Authored by lebedev.ri on Mar 10 2019, 3:40 PM.

Details

Summary

These ObjC AST classes inherit from Stmt, but don't call VisitStmt(S);.
Some were founded with help of existing tests (with NumStmtFields bumped to 1),
but some of them don't even have PCH test coverage. :/

Diff Detail

Repository
rC Clang

Event Timeline

lebedev.ri created this revision.Mar 10 2019, 3:40 PM

How can this change be NFC?

How can this change be NFC?

VisitStmt() is empty currently, there is currently no data serialized by the Stmt itself.
D59214 changes that.

jordan_rose accepted this revision.Mar 11 2019, 10:20 AM

I'm no Clang serialization expert but this makes sense to me. It's consistent with all the other statement visitor methods.

This revision is now accepted and ready to land.Mar 11 2019, 10:20 AM

I'm no Clang serialization expert but this makes sense to me. It's consistent with all the other statement visitor methods.

Thank you.

This revision was automatically updated to reflect the committed changes.