This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Remove empty header xlocale/xlocale.h
ClosedPublic

Authored by ldionne on Mar 8 2019, 9:19 AM.

Details

Summary

I can't think of a reason for shipping this empty header. If there is
a reason to do so, then hopefully this review can uncover it.

Diff Detail

Repository
rL LLVM

Event Timeline

ldionne created this revision.Mar 8 2019, 9:19 AM

It was added as part of https://reviews.llvm.org/D17416, and that is all it's ever been.

It was added as part of https://reviews.llvm.org/D17416, and that is all it's ever been.

Ah, thanks for digging this up. So basically the contents of the file were deleted but the file itself wasn't removed. So it seems like it's safe to remove it.

So basically the contents of the file were deleted but the file itself wasn't removed

I don't think that's right. I think that it was created empty.

EricWF accepted this revision.Mar 8 2019, 8:28 PM

So basically the contents of the file were deleted but the file itself wasn't removed

I don't think that's right. I think that it was created empty.

The patch says the file was deleted, and it shows the old contents of the header.
Somehow SVN didn't delete the file.

LGTM.

This revision is now accepted and ready to land.Mar 8 2019, 8:28 PM
mclow.lists accepted this revision.Mar 11 2019, 8:15 AM

I'm fine with this.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 11 2019, 8:42 AM