This is an archive of the discontinued LLVM Phabricator instance.

Differential D59084

[clangd] Remove ./ and ../ in the file paths
ClosedPublic

Authored by kadircet on Mar 7 2019, 2:55 AM.

Details

Reviewers
hokein
Commits
rG890dfddef0f9: [clangd] Remove ./ and ../ in the file paths
rL355681: [clangd] Remove ./ and ../ in the file paths
rCTE355681: [clangd] Remove ./ and ../ in the file paths

Diff Detail

Event Timeline

kadircet created this revision.Mar 7 2019, 2:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2019, 2:55 AM
Herald added subscribers: cfe-commits, arphaman, jkorous and 3 others. · View Herald Transcript
Harbormaster completed remote builds in B28882: Diff 189677.Mar 7 2019, 2:58 AM
hokein accepted this revision.Mar 7 2019, 4:47 AM

It would be nicer to have a unittest (if it doesn't take too much effort to create one).

This revision is now accepted and ready to land.Mar 7 2019, 4:47 AM
kadircet updated this revision to Diff 189828.Mar 8 2019, 1:32 AM
  • Add tests
Herald added a subscriber: jdoerfert. · View Herald TranscriptMar 8 2019, 1:32 AM
Harbormaster completed remote builds in B28920: Diff 189828.Mar 8 2019, 1:33 AM
Closed by commit rCTE355681: [clangd] Remove ./ and ../ in the file paths (authored by kadircet). · Explain WhyMar 8 2019, 1:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clangd/
index/
1 line

Diff 189677

clangd/index/Background.cpp

Show First 20 Lines • Show All 115 Lines • ▼ Show 20 Lines
// directory. // directory.
llvm::SmallString<128> getAbsolutePath(const tooling::CompileCommand &Cmd) { llvm::SmallString<128> getAbsolutePath(const tooling::CompileCommand &Cmd) {
llvm::SmallString<128> AbsolutePath; llvm::SmallString<128> AbsolutePath;
if (llvm::sys::path::is_absolute(Cmd.Filename)) { if (llvm::sys::path::is_absolute(Cmd.Filename)) {
AbsolutePath = Cmd.Filename; AbsolutePath = Cmd.Filename;
} else { } else {
AbsolutePath = Cmd.Directory; AbsolutePath = Cmd.Directory;
llvm::sys::path::append(AbsolutePath, Cmd.Filename); llvm::sys::path::append(AbsolutePath, Cmd.Filename);
llvm::sys::path::remove_dots(AbsolutePath, true);
} }
return AbsolutePath; return AbsolutePath;
} }
} // namespace } // namespace
BackgroundIndex::BackgroundIndex( BackgroundIndex::BackgroundIndex(
Context BackgroundContext, const FileSystemProvider &FSProvider, Context BackgroundContext, const FileSystemProvider &FSProvider,
const GlobalCompilationDatabase &CDB, const GlobalCompilationDatabase &CDB,
▲ Show 20 Lines • Show All 480 Lines • Show Last 20 Lines