Page MenuHomePhabricator

[ExpressionParser] Implement ComputeClangResourceDir for Windows
ClosedPublic

Authored by xiaobai on Mar 6 2019, 7:15 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

xiaobai created this revision.Mar 6 2019, 7:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2019, 7:15 PM
labath accepted this revision.Mar 7 2019, 12:37 AM

lgtm

This revision is now accepted and ready to land.Mar 7 2019, 12:37 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2019, 12:08 PM

This broke the Windows bot because now one of the TestPaths tests passes on Windows:

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/2394

There's also this comment in the test file:

  1. TODO: Merge into test_path when GetClangResourceDir is implemented on
  2. windows

This broke the Windows bot because now one of the TestPaths tests passes on Windows:

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/2394

There's also this comment in the test file:

  1. TODO: Merge into test_path when GetClangResourceDir is implemented on
  2. windows

Submitted a forward fix with rL355648