Page MenuHomePhabricator

[NFC][TSan] Add libdispatch tests for non-Darwin platforms
ClosedPublic

Authored by yln on Mar 6 2019, 1:37 PM.

Details

Summary

Add new sets of tests (copy instead of move existing tests) because
there could be subtle differences between C/Obj-C and with/without
Foundation etc.

Diff Detail

Repository
rL LLVM

Event Timeline

yln created this revision.Mar 6 2019, 1:37 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 6 2019, 1:37 PM
Herald added subscribers: llvm-commits, Restricted Project, jdoerfert and 2 others. · View Herald Transcript
yln added a comment.Mar 6 2019, 1:43 PM

This adds a first batch of tests (those that were easy to adapt) for libdispatch on non-Darwin platforms.
All tests are guarded via // REQUIRES: dispatch.

I will follow up with a patch that will include additional tests from the GCD Darwin suite. Main issues with those tests is that the use Foundation (CFRunLoop/CFRunLoopStop) for test setup and scheduling.

dvyukov accepted this revision.Mar 6 2019, 10:12 PM
This revision is now accepted and ready to land.Mar 6 2019, 10:12 PM
This revision was automatically updated to reflect the committed changes.