[debugserver] Fix IsUserReady thread filtering

[friss]

Summary

In 2010 (r118866), filtering code was added to debugserver to avoid reporting threads
that were "not ready to be displayed to the user". This code inspects the thread's
state and discards threads marked 'uninterruptible'. Turns out, this state is pretty
common and not only a characterisitic of 'user-readiness'. This filtering was tracked
down as the source of the flakiness of TestQueues and TestConcurrent* with the symptom
of missing threads.

We discussed with the kernel team and there should be no need for us to filter the
restult of task_threads(). Everything that is returned from there can be examined.
So I went on and tried to remove the filtering completely. This produces other test
failures, where we were reporting more theads than expected. Always threads that had
been terminated, but weren't removed from the task bookkeeping structures yet. Those
threads always had a PC of 0.

This patch changes the heuristic to make the filtering a little less strict and only
rejects threads that are 'uninteruptible' *and* have a PC of 0. This has proven to be
solid in my testing.

[jasonmolenda]

Will this hide a thread that jumps through a null function pointer? That's the only user process case where a pc of 0 needs to be reported to the developer.

[friss]

In D58912#1417570, @jasonmolenda wrote:

Will this hide a thread that jumps through a null function pointer? That's the only user process case where a pc of 0 needs to be reported to the developer.

Nope, I tested this explicitly and when we crash through a NULL pointer the backtrace is correct. Note that the added test is exercised only in the case where the thread state is TH_STATE_UNINTERRUPTIBLE, which seems to be very special (and not what you get when crashed).

[jasonmolenda]

Looks good, that was my only concern.

tools/debugserver/source/MacOSX/MachThread.cpp

case TH_STATE_UNINTERRUPTIBLE:
     break;
 
   case TH_STATE_RUNNING:
   case TH_STATE_STOPPED:
   case TH_STATE_WAITING:
   case TH_STATE_HALTED:
     return true;
   }
-  return false;
+  return GetPC(0) != 0;
 }
 
 struct thread_basic_info *MachThread::GetBasicInfo() {
   if (MachThread::GetBasicInfo(m_mach_port_number, &m_basic_info))
     return &m_basic_info;
   return NULL;
 }