[clangd] Make sure constructors do not reference class

[gribozavr]

unittests/clangd/XRefsTests.cpp

1370

Add the new test right after the "Method call" test, to keep it grouped? Constructor calls are kinda like method calls.

[kadircet]

Re-arrange test location

[kadircet]

• Make use of NameReference symbol role

[gribozavr]

clangd/XRefs.cpp

160 ↗

(On Diff #189831)

Maybe add a blank line so that it is clear that the comment is only attached to the if stmt?

[kadircet]

• Address comments

unittests/clangd/XRefsTests.cpp

const char *Tests[] = {
         struct Foo { int [[foo]](); };
         int Foo::[[foo]]() {}
         int main() {
           Foo f;
           f.[[^foo]]();
         }
       )cpp",
 
+      R"cpp(// Constructor
+        struct Foo {
+          [[F^oo]](int);
+        };
+        void foo() {
+          Foo f = [[Foo]](42);
+        }
+      )cpp",
+
       R"cpp(// Typedef
         typedef int [[Foo]];
         int main() {
           [[^Foo]] bar;
         }
       )cpp",
 
       R"cpp(// Namespace
         namespace [[ns]] {
         struct Foo {};
         } // namespace ns
         int main() { [[^ns]]::Foo foo; }
       )cpp",
   };
   for (const char *Test : Tests) {
     Annotations T(Test);
     auto AST = TestTU::withCode(T.code()).build();
     std::vector<Matcher<Location>> ExpectedLocations;
     for (const auto &R : T.ranges())
       ExpectedLocations.push_back(RangeIs(R));
     EXPECT_THAT(findReferences(AST, T.point(), 0),
                 ElementsAreArray(ExpectedLocations))
         << Test;
   }
 }
 
 TEST(FindReferences, ExplicitSymbols) {
   const char *Tests[] = {
       R"cpp(
       struct Foo { Foo* [self]() const; };