Page MenuHomePhabricator

[clangd] Make sure constructors do not reference class
ClosedPublic

Authored by kadircet on Mar 1 2019, 2:33 AM.

Diff Detail

Event Timeline

kadircet created this revision.Mar 1 2019, 2:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2019, 2:33 AM
gribozavr accepted this revision.Mar 1 2019, 3:14 AM
gribozavr added inline comments.
unittests/clangd/XRefsTests.cpp
1370

Add the new test right after the "Method call" test, to keep it grouped? Constructor calls are kinda like method calls.

This revision is now accepted and ready to land.Mar 1 2019, 3:14 AM
kadircet updated this revision to Diff 188878.Mar 1 2019, 4:20 AM
kadircet marked an inline comment as done.

Re-arrange test location

kadircet updated this revision to Diff 189831.Mar 8 2019, 1:47 AM
  • Make use of NameReference symbol role
gribozavr accepted this revision.Mar 8 2019, 1:50 AM
gribozavr added inline comments.
clangd/XRefs.cpp
160

Maybe add a blank line so that it is clear that the comment is only attached to the if stmt?

kadircet updated this revision to Diff 189832.Mar 8 2019, 1:52 AM
kadircet marked an inline comment as done.
  • Address comments
This revision was automatically updated to reflect the committed changes.