Page MenuHomePhabricator

Moved Ref into its own header and implementation file
ClosedPublic

Authored by gribozavr on Feb 28 2019, 5:25 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

gribozavr created this revision.Feb 28 2019, 5:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2019, 5:25 AM
ioeric added inline comments.Feb 28 2019, 5:30 AM
clang-tools-extra/clangd/index/Ref.cpp
1 ↗(On Diff #188717)

License?

clang-tools-extra/clangd/index/SymbolCollector.cpp
14 ↗(On Diff #188717)

Is this change relevant in this patch?

clang-tools-extra/clangd/indexer/IndexerMain.cpp
16 ↗(On Diff #188717)

Maybe also include Ref.h?

gribozavr updated this revision to Diff 188723.Feb 28 2019, 5:39 AM
gribozavr marked an inline comment as done.

Added a license header.

gribozavr updated this revision to Diff 188724.Feb 28 2019, 5:40 AM
gribozavr marked 2 inline comments as done.

Added a missing include.

gribozavr marked 2 inline comments as done.Feb 28 2019, 5:40 AM
gribozavr added inline comments.
clang-tools-extra/clangd/index/Ref.cpp
1 ↗(On Diff #188717)

Added.

clang-tools-extra/clangd/index/SymbolCollector.cpp
14 ↗(On Diff #188717)

Yes, once I replaced inclusion of Index.h with a more specific file somewhere else, SymbolCollector.cpp stopped building because it relied on transitive inclusion of ExpectedTypes.h.

clang-tools-extra/clangd/indexer/IndexerMain.cpp
16 ↗(On Diff #188717)

Added.

ioeric accepted this revision.Feb 28 2019, 5:43 AM
This revision is now accepted and ready to land.Feb 28 2019, 5:43 AM
This revision was automatically updated to reflect the committed changes.
gribozavr marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2019, 5:49 AM