This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Provide better llvm-lit failure when llvm-config fails.
ClosedPublic

Authored by hctim on Feb 25 2019, 2:58 PM.

Details

Summary

The current error message can cause confusion if llvm-config can't be
executed for reasons other than "not found". In my example, cross
compiling generated an llvm-config binary for aarch64 which couldn't be
executed natively. Instead of telling me that the error was with the
file architecture, it reports the file as not being present.

Event Timeline

hctim created this revision.Feb 25 2019, 2:58 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 25 2019, 2:58 PM
Herald added subscribers: llvm-commits, Restricted Project, jdoerfert and 3 others. · View Herald Transcript
hctim updated this revision to Diff 188261.Feb 25 2019, 3:15 PM
  • Fixed a minor merge error with this patch.
eugenis accepted this revision.Feb 25 2019, 5:26 PM
eugenis added a subscriber: eugenis.

LGTM

This revision is now accepted and ready to land.Feb 25 2019, 5:26 PM
This revision was automatically updated to reflect the committed changes.