This is an archive of the discontinued LLVM Phabricator instance.

[libclang] Fix a trivial error introduced in D57946.
ClosedPublic

Authored by emilio on Feb 22 2019, 8:39 PM.

Download Raw Diff

Details

Reviewers

Anastasia
arphaman
serge-sans-paille

Commits

rG76004da1c912: [libclang] Fix a trivial error introduced in D57946.
rC354823: [libclang] Fix a trivial error introduced in D57946.
rL354823: [libclang] Fix a trivial error introduced in D57946.

Summary

The value for CXCursor_ConvergentAttr is not 420. I'm not really sure how easy
it is to test this, and I'm not familiar with the python bindings, just noticed
the error while looking at D57946 to write D58570.

Diff Detail

Repository: rL LLVM

Event Timeline

emilio created this revision.Feb 22 2019, 8:39 PM

Herald added a reviewer: serge-sans-paille. · View Herald TranscriptFeb 22 2019, 8:39 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added a subscriber: cfe-commits. · View Herald Transcript

Harbormaster completed remote builds in B28445: Diff 188027.Feb 22 2019, 8:39 PM

LGTM! Thanks! I guess we are missing a python test? No idea why we are not testing it though...

This revision is now accepted and ready to land.Feb 25 2019, 3:02 AM

Herald added a subscriber: Charusso. · View Herald TranscriptFeb 25 2019, 3:02 AM

Charusso removed a subscriber: Charusso.Feb 25 2019, 3:09 AM

Closed by commit rL354823: [libclang] Fix a trivial error introduced in D57946. (authored by emilio). · Explain WhyFeb 25 2019, 1:14 PM

This revision was automatically updated to reflect the committed changes.

Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2019, 1:14 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

Path

Size

cfe/

trunk/

bindings/

python/

clang/

cindex.py

2 lines

Diff 188249

cfe/trunk/bindings/python/clang/cindex.py

	Show First 20 Lines • Show All 1,336 Lines • ▼ Show 20 Lines
	CursorKind.CUDAGLOBAL_ATTR = CursorKind(414)			CursorKind.CUDAGLOBAL_ATTR = CursorKind(414)
	CursorKind.CUDAHOST_ATTR = CursorKind(415)			CursorKind.CUDAHOST_ATTR = CursorKind(415)
	CursorKind.CUDASHARED_ATTR = CursorKind(416)			CursorKind.CUDASHARED_ATTR = CursorKind(416)

	CursorKind.VISIBILITY_ATTR = CursorKind(417)			CursorKind.VISIBILITY_ATTR = CursorKind(417)

	CursorKind.DLLEXPORT_ATTR = CursorKind(418)			CursorKind.DLLEXPORT_ATTR = CursorKind(418)
	CursorKind.DLLIMPORT_ATTR = CursorKind(419)			CursorKind.DLLIMPORT_ATTR = CursorKind(419)
	CursorKind.CONVERGENT_ATTR = CursorKind(420)			CursorKind.CONVERGENT_ATTR = CursorKind(438)

	###			###
	# Preprocessing			# Preprocessing
	CursorKind.PREPROCESSING_DIRECTIVE = CursorKind(500)			CursorKind.PREPROCESSING_DIRECTIVE = CursorKind(500)
	CursorKind.MACRO_DEFINITION = CursorKind(501)			CursorKind.MACRO_DEFINITION = CursorKind(501)
	CursorKind.MACRO_INSTANTIATION = CursorKind(502)			CursorKind.MACRO_INSTANTIATION = CursorKind(502)
	CursorKind.INCLUSION_DIRECTIVE = CursorKind(503)			CursorKind.INCLUSION_DIRECTIVE = CursorKind(503)

	▲ Show 20 Lines • Show All 2,861 Lines • Show Last 20 Lines