Page MenuHomePhabricator

emilio (Emilio Cobos Álvarez)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 7 2016, 7:34 PM (140 w, 4 d)

Recent Activity

Tue, Jul 9

emilio committed rG743754501b36: [libclang] Fix hang in release / assertion in debug when evaluating value… (authored by emilio).
[libclang] Fix hang in release / assertion in debug when evaluating value…
Tue, Jul 9, 7:28 AM
emilio committed rL365490: [libclang] Fix hang in release / assertion in debug when evaluating value….
[libclang] Fix hang in release / assertion in debug when evaluating value…
Tue, Jul 9, 7:27 AM
emilio added a comment to D64409: [libclang] Fix hang in release / assertion in debug when evaluating value-dependent types..

Thanks for the review as always @Anastasia ^.^

Tue, Jul 9, 7:27 AM · Restricted Project, Restricted Project
emilio closed D64409: [libclang] Fix hang in release / assertion in debug when evaluating value-dependent types..
Tue, Jul 9, 7:27 AM · Restricted Project, Restricted Project
emilio created D64409: [libclang] Fix hang in release / assertion in debug when evaluating value-dependent types..
Tue, Jul 9, 6:03 AM · Restricted Project, Restricted Project
emilio updated the summary of D64409: [libclang] Fix hang in release / assertion in debug when evaluating value-dependent types..
Tue, Jul 9, 6:03 AM · Restricted Project, Restricted Project

Mar 13 2019

emilio committed rGcd74127d28c1: [libclang] Expose aligned() attribute. (authored by emilio).
[libclang] Expose aligned() attribute.
Mar 13 2019, 9:20 AM
emilio added a comment to D59299: [libclang] Expose aligned() attribute..

Thank you for the review! :)

Mar 13 2019, 9:19 AM · Restricted Project, Restricted Project
emilio committed rC356062: [libclang] Expose aligned() attribute..
[libclang] Expose aligned() attribute.
Mar 13 2019, 9:16 AM
emilio committed rL356062: [libclang] Expose aligned() attribute..
[libclang] Expose aligned() attribute.
Mar 13 2019, 9:16 AM
emilio closed D59299: [libclang] Expose aligned() attribute..
Mar 13 2019, 9:16 AM · Restricted Project, Restricted Project
emilio created D59299: [libclang] Expose aligned() attribute..
Mar 13 2019, 7:38 AM · Restricted Project, Restricted Project

Feb 26 2019

emilio committed rG0d76dc285c17: [libclang] Avoid crashing when getting layout info of an undeduced type. (authored by emilio).
[libclang] Avoid crashing when getting layout info of an undeduced type.
Feb 26 2019, 7:04 AM
emilio committed rL354885: [libclang] Avoid crashing when getting layout info of an undeduced type..
[libclang] Avoid crashing when getting layout info of an undeduced type.
Feb 26 2019, 7:04 AM
emilio committed rC354885: [libclang] Avoid crashing when getting layout info of an undeduced type..
[libclang] Avoid crashing when getting layout info of an undeduced type.
Feb 26 2019, 7:04 AM
emilio added a comment to D58569: [libclang] Avoid crashing when getting layout info of an undeduced type..

Thank you for all the reviews! :)

Feb 26 2019, 7:03 AM · Restricted Project
emilio closed D58569: [libclang] Avoid crashing when getting layout info of an undeduced type..
Feb 26 2019, 7:03 AM · Restricted Project

Feb 25 2019

emilio added a comment to D58569: [libclang] Avoid crashing when getting layout info of an undeduced type..

Huh, somehow forgot to press "Submit" this morning :)

Feb 25 2019, 9:54 PM · Restricted Project
emilio added a comment to D58570: [libclang] Expose warn_unused and warn_unused_result attributes..

Landed with that change, thanks for the review @Anastasia!

Feb 25 2019, 1:47 PM · Restricted Project
emilio updated the diff for D58569: [libclang] Avoid crashing when getting layout info of an undeduced type..

Add CHECK tests.

Feb 25 2019, 1:42 PM · Restricted Project
emilio committed rG0a3fe502e645: [libclang] Expose warn_unused and warn_unused_result attributes. (authored by emilio).
[libclang] Expose warn_unused and warn_unused_result attributes.
Feb 25 2019, 1:25 PM
emilio committed rC354824: [libclang] Expose warn_unused and warn_unused_result attributes..
[libclang] Expose warn_unused and warn_unused_result attributes.
Feb 25 2019, 1:24 PM
emilio committed rL354824: [libclang] Expose warn_unused and warn_unused_result attributes..
[libclang] Expose warn_unused and warn_unused_result attributes.
Feb 25 2019, 1:24 PM
emilio closed D58570: [libclang] Expose warn_unused and warn_unused_result attributes..
Feb 25 2019, 1:24 PM · Restricted Project
emilio committed rG76004da1c912: [libclang] Fix a trivial error introduced in D57946. (authored by emilio).
[libclang] Fix a trivial error introduced in D57946.
Feb 25 2019, 1:15 PM
emilio committed rC354823: [libclang] Fix a trivial error introduced in D57946..
[libclang] Fix a trivial error introduced in D57946.
Feb 25 2019, 1:15 PM
emilio committed rL354823: [libclang] Fix a trivial error introduced in D57946..
[libclang] Fix a trivial error introduced in D57946.
Feb 25 2019, 1:14 PM
emilio closed D58571: [libclang] Fix a trivial error introduced in D57946..
Feb 25 2019, 1:14 PM · Restricted Project, Restricted Project
emilio added inline comments to D58569: [libclang] Avoid crashing when getting layout info of an undeduced type..
Feb 25 2019, 7:57 AM · Restricted Project

Feb 22 2019

emilio created D58571: [libclang] Fix a trivial error introduced in D57946..
Feb 22 2019, 8:39 PM · Restricted Project, Restricted Project
emilio created D58570: [libclang] Expose warn_unused and warn_unused_result attributes..
Feb 22 2019, 8:35 PM · Restricted Project
emilio added reviewers for D58569: [libclang] Avoid crashing when getting layout info of an undeduced type.: arphaman, Anastasia.
Feb 22 2019, 7:19 PM · Restricted Project
emilio created D58569: [libclang] Avoid crashing when getting layout info of an undeduced type..
Feb 22 2019, 7:18 PM · Restricted Project

May 2 2017

emilio added a comment to D32566: Revert rL301328 and add tests for the regressions introduced..

I sent http://lists.llvm.org/pipermail/cfe-dev/2017-May/053703.html

May 2 2017, 3:13 AM · Restricted Project
emilio committed rL301906: Remove leftover test expectation from rL301902..
Remove leftover test expectation from rL301902.
May 2 2017, 3:10 AM
emilio committed rL301902: [libclang] Revert rL301328 and add tests for the regressions introduced..
[libclang] Revert rL301328 and add tests for the regressions introduced.
May 2 2017, 1:45 AM
emilio added a reverting change for rL301328: [libclang] Check for a record declaration before a template specialization: rL301902: [libclang] Revert rL301328 and add tests for the regressions introduced..
May 2 2017, 1:45 AM
emilio closed D32566: Revert rL301328 and add tests for the regressions introduced. by committing rL301902: [libclang] Revert rL301328 and add tests for the regressions introduced..
May 2 2017, 1:45 AM · Restricted Project

Apr 28 2017

emilio committed rL301648: [libclang] Expose some target information via the C API..
[libclang] Expose some target information via the C API.
Apr 28 2017, 9:09 AM
emilio closed D32389: [libclang] Expose some target information via the C API. by committing rL301648: [libclang] Expose some target information via the C API..
Apr 28 2017, 9:09 AM · Restricted Project

Apr 27 2017

emilio added a comment to D32566: Revert rL301328 and add tests for the regressions introduced..

I'm personally fine with this behavior in particular, given you can check the cursor you're querying to know if it's a typedef or alias specialization. Of course I'm not the only one using libclang, though, so I'd be interested in hearing other people's opinion.

Apr 27 2017, 6:38 AM · Restricted Project

Apr 26 2017

emilio added a comment to D32348: [libclang] Check for a record declaration before a template specialization..

FWIW when I wrote D26663, I did it because arguments weren't inspectionable at all for using declarations. Actually both of them would've worked for me.

Apr 26 2017, 3:47 PM · Restricted Project
emilio added a comment to D32348: [libclang] Check for a record declaration before a template specialization..

Revert + tests @ https://reviews.llvm.org/D32566

Apr 26 2017, 3:45 PM · Restricted Project
emilio created D32566: Revert rL301328 and add tests for the regressions introduced..
Apr 26 2017, 3:43 PM · Restricted Project
emilio updated the diff for D32389: [libclang] Expose some target information via the C API..

Updated per review comments, thanks :)

Apr 26 2017, 3:14 PM · Restricted Project
emilio added a comment to D32348: [libclang] Check for a record declaration before a template specialization..

This change looks like it introduces a regression itself: given

template<typename T> struct A {};
template<typename T> using B = A<T*>;
B<int> bi;

... requesting the template arguments for the type B<int> changes from producing int to producing int* with this patch, which seems to directly oppose the intentions of D26663.

Apr 26 2017, 3:11 PM · Restricted Project

Apr 25 2017

emilio updated the diff for D32389: [libclang] Expose some target information via the C API..

Updated per comments, I used clang_TargetInfo_dispose following recent APIs instead of clang_disposeTargetInfo, let me know if I should change that.

Apr 25 2017, 5:12 PM · Restricted Project
emilio added a comment to rL301328: [libclang] Check for a record declaration before a template specialization.

Err, that comment was supposed to be a reply to https://reviews.llvm.org/D32348#737058, oh well, thanks again :)

Apr 25 2017, 11:51 AM
emilio added a comment to rL301328: [libclang] Check for a record declaration before a template specialization.

Thanks a lot for the tip! :)

Apr 25 2017, 11:50 AM
emilio added a comment to D32389: [libclang] Expose some target information via the C API..

Sounds good to me, will do :)

Apr 25 2017, 9:27 AM · Restricted Project
emilio added a comment to D32348: [libclang] Check for a record declaration before a template specialization..

Yes, please! I've submitted a few patches, but still no commit access.

Apr 25 2017, 9:26 AM · Restricted Project

Apr 22 2017

emilio added a comment to D32389: [libclang] Expose some target information via the C API..

I'd appreciate if anyone could point me to an appropriate reviewer for this.

Apr 22 2017, 8:43 AM · Restricted Project
emilio created D32389: [libclang] Expose some target information via the C API..
Apr 22 2017, 8:42 AM · Restricted Project

Apr 21 2017

emilio added inline comments to D32348: [libclang] Check for a record declaration before a template specialization..
Apr 21 2017, 10:36 AM · Restricted Project
emilio updated the diff for D32348: [libclang] Check for a record declaration before a template specialization..

Full diff, thanks @arphaman :)

Apr 21 2017, 6:37 AM · Restricted Project
emilio created D32348: [libclang] Check for a record declaration before a template specialization..
Apr 21 2017, 6:16 AM · Restricted Project
emilio abandoned D31732: [libclang] Check for a record declaration before a template specialization..

Closing per advice in cfe-commits@.

Apr 21 2017, 6:07 AM · Restricted Project

Apr 20 2017

emilio added a comment to D31732: [libclang] Check for a record declaration before a template specialization..

Ping?

Apr 20 2017, 12:22 PM · Restricted Project

Apr 11 2017

emilio added a comment to D31732: [libclang] Check for a record declaration before a template specialization..

Guy, perhaps you could also review this? (Just from looking at the blame log).

Apr 11 2017, 6:51 PM · Restricted Project
emilio added a reviewer for D31732: [libclang] Check for a record declaration before a template specialization.: gbenyei.
Apr 11 2017, 6:50 PM · Restricted Project

Apr 5 2017

emilio created D31732: [libclang] Check for a record declaration before a template specialization..
Apr 5 2017, 4:19 PM · Restricted Project

Dec 16 2016

emilio added a comment to D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.

@skalinichev ping? Anything else I need to do to get this landed?

Dec 16 2016, 1:09 AM · Restricted Project

Dec 13 2016

emilio updated the diff for D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.

Now without a really dumb off-by-one, hidden by the fact that we always indexed in-range and packs are only the last element.

Dec 13 2016, 4:24 PM · Restricted Project
emilio updated the diff for D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.

Actually it was not so bad, thanks @skalinichev :)

Dec 13 2016, 10:14 AM · Restricted Project
emilio added inline comments to D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.
Dec 13 2016, 9:58 AM · Restricted Project

Dec 12 2016

emilio updated the diff for D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.

Thanks for the review, good catches :)

Dec 12 2016, 11:11 PM · Restricted Project

Dec 4 2016

emilio updated the diff for D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.

Updated per comments. Not super happy with making these functions linear, but given template arguments aren't that numerous usually, it's probably acceptable.

Dec 4 2016, 3:50 PM · Restricted Project
emilio updated the diff for D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.

Updated per comments, let me know if I should do anything else.

Dec 4 2016, 2:57 AM · Restricted Project
emilio added inline comments to D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.
Dec 4 2016, 2:17 AM · Restricted Project
emilio added a comment to D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.

Thanks for the comments!

Dec 4 2016, 2:16 AM · Restricted Project

Dec 3 2016

emilio added a comment to D26663: libclang: Generalize clang_getNumTemplateArguments and clang_getTemplateArgumentAsType to other kind of specializations..

@skalinichev Yeah, I noticed that and published https://reviews.llvm.org/D26907 a while ago, it hasn't been accepted yet though.

Dec 3 2016, 7:58 AM · Restricted Project
emilio added a comment to D26446: libclang: Avoid returning an extra token in clang_tokenize.

Sorry @skalinichev, didn't know about those. Thanks for fixing.

Dec 3 2016, 7:56 AM

Dec 2 2016

emilio updated the diff for D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.

Now with proper tests :)

Dec 2 2016, 10:25 AM · Restricted Project
emilio added a comment to D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.

Hmm... You're right.

Dec 2 2016, 10:00 AM · Restricted Project

Nov 24 2016

emilio added a comment to D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.

(Also, please don't rush if I'm wrong being concerned about releases or similar, I'm fairly ignorant in that regard)

Nov 24 2016, 2:09 PM · Restricted Project
emilio added a comment to D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.

Hi, @EricWF or @akyrtzi, could I get this reviewed?

Nov 24 2016, 12:19 PM · Restricted Project
emilio updated the diff for D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.

Updated to add a missing null check, and remove unnecessary diff noise.

Nov 24 2016, 12:18 PM · Restricted Project

Nov 21 2016

emilio retitled D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType from to libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.
Nov 21 2016, 3:15 AM · Restricted Project

Nov 16 2016

emilio retitled D26788: libclang: Add APIs to check the result of an integer expression in CXEvalResult without overflow. from to libclang: Add APIs to check the result of an integer expression in CXEvalResult without overflow..
Nov 16 2016, 7:22 PM · Restricted Project

Nov 15 2016

emilio updated the diff for D26663: libclang: Generalize clang_getNumTemplateArguments and clang_getTemplateArgumentAsType to other kind of specializations..

Updated to use LLVM's coding style (with the star to the right), and also to reflect that template argument packs are now inspectionable.

Nov 15 2016, 2:59 AM · Restricted Project
emilio retitled D26663: libclang: Generalize clang_getNumTemplateArguments and clang_getTemplateArgumentAsType to other kind of specializations. from to libclang: Generalize clang_getNumTemplateArguments and clang_getTemplateArgumentAsType to other kind of specializations..
Nov 15 2016, 2:54 AM · Restricted Project

Nov 10 2016

emilio added a comment to D26446: libclang: Avoid returning an extra token in clang_tokenize.

Thanks for commiting the patch @akyrtzi (and for fixing up the test path, I kind of suspected there had to be a better place for it but didn't look too close apparently :P).

Nov 10 2016, 1:22 AM

Nov 9 2016

emilio updated the diff for D26446: libclang: Avoid returning an extra token in clang_tokenize.

Updated per comments, let me know if I can do anything else, thanks!

Nov 9 2016, 12:07 PM
emilio added a comment to D26446: libclang: Avoid returning an extra token in clang_tokenize.

I thought the extra test would be helpful since I'm not aware of any test that used clang_getCursorExtent + clang_tokenize, but I guess I can revert that, no problem. Thanks for the review! :)

Nov 9 2016, 11:52 AM
emilio added a comment to D26446: libclang: Avoid returning an extra token in clang_tokenize.

Guy, I added you as a reviewer looking at the blame log, feel free to redirect since it's my first patch to LLVM. Thanks!

Nov 9 2016, 3:53 AM
emilio retitled D26446: libclang: Avoid returning an extra token in clang_tokenize from to libclang: Avoid returning an extra token in clang_tokenize.
Nov 9 2016, 3:52 AM