This is an archive of the discontinued LLVM Phabricator instance.

Differential D58526

AMDGPU: Don't emit debugger subtarget features
ClosedPublic

Authored by arsenm on Feb 21 2019, 12:40 PM.

Details

Reviewers
yaxunl
kzhuravl
t-tye
Summary

Keep the flag around for compatability.

Diff Detail

Event Timeline

arsenm created this revision.Feb 21 2019, 12:40 PM
Herald added subscribers: jdoerfert, tpr, dstuttard and 3 others. · View Herald TranscriptFeb 21 2019, 12:40 PM
kzhuravl added inline comments.Feb 21 2019, 12:44 PM
test/Driver/amdgpu-features.c
7

I do not see this prefix in the run line?

arsenm updated this revision to Diff 187849.Feb 21 2019, 1:01 PM

Undelete run line

kzhuravl accepted this revision.Feb 21 2019, 1:04 PM

LGTM

This revision is now accepted and ready to land.Feb 21 2019, 1:04 PM
arsenm closed this revision.Feb 21 2019, 1:31 PM

r354624

Revision Contents

PathSize
lib/
Driver/
ToolChains/
11 lines
test/
Driver/
2 lines

Diff 187849

lib/Driver/ToolChains/AMDGPU.cpp

Show All 32 Linesvoid amdgpu::Linker::ConstructJob(Compilation &C, const JobAction &JA,
CmdArgs.push_back(Output.getFilename()); CmdArgs.push_back(Output.getFilename());
C.addCommand(llvm::make_unique<Command>(JA, *this, Args.MakeArgString(Linker), C.addCommand(llvm::make_unique<Command>(JA, *this, Args.MakeArgString(Linker),
CmdArgs, Inputs)); CmdArgs, Inputs));
} }
void amdgpu::getAMDGPUTargetFeatures(const Driver &D, void amdgpu::getAMDGPUTargetFeatures(const Driver &D,
const llvm::opt::ArgList &Args, const llvm::opt::ArgList &Args,
std::vector<StringRef> &Features) { std::vector<StringRef> &Features) {
if (const Arg *dAbi = Args.getLastArg(options::OPT_mamdgpu_debugger_abi)) { if (const Arg *dAbi = Args.getLastArg(options::OPT_mamdgpu_debugger_abi))
StringRef value = dAbi->getValue();
if (value == "1.0") {
Features.push_back("+amdgpu-debugger-insert-nops");
Features.push_back("+amdgpu-debugger-emit-prologue");
} else {
D.Diag(diag::err_drv_clang_unsupported) << dAbi->getAsString(Args); D.Diag(diag::err_drv_clang_unsupported) << dAbi->getAsString(Args);
}
}
handleTargetFeaturesGroup( handleTargetFeaturesGroup(
Args, Features, options::OPT_m_amdgpu_Features_Group); Args, Features, options::OPT_m_amdgpu_Features_Group);
} }
/// AMDGPU Toolchain /// AMDGPU Toolchain
AMDGPUToolChain::AMDGPUToolChain(const Driver &D, const llvm::Triple &Triple, AMDGPUToolChain::AMDGPUToolChain(const Driver &D, const llvm::Triple &Triple,
const ArgList &Args) const ArgList &Args)
▲ Show 20 Lines • Show All 56 Lines • Show Last 20 Lines

test/Driver/amdgpu-features.c

// RUN: %clang -### -target amdgcn -x cl -S -emit-llvm -mcpu=kaveri -mamdgpu-debugger-abi=0.0 %s -o - 2>&1 \ // RUN: %clang -### -target amdgcn -x cl -S -emit-llvm -mcpu=kaveri -mamdgpu-debugger-abi=0.0 %s -o - 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-MAMDGPU-DEBUGGER-ABI-0-0 %s // RUN: | FileCheck --check-prefix=CHECK-MAMDGPU-DEBUGGER-ABI-0-0 %s
// CHECK-MAMDGPU-DEBUGGER-ABI-0-0: the clang compiler does not support '-mamdgpu-debugger-abi=0.0' // CHECK-MAMDGPU-DEBUGGER-ABI-0-0: the clang compiler does not support '-mamdgpu-debugger-abi=0.0'
// RUN: %clang -### -target amdgcn -x cl -S -emit-llvm -mcpu=kaveri -mamdgpu-debugger-abi=1.0 %s -o - 2>&1 \ // RUN: %clang -### -target amdgcn -x cl -S -emit-llvm -mcpu=kaveri -mamdgpu-debugger-abi=1.0 %s -o - 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-MAMDGPU-DEBUGGER-ABI-1-0 %s // RUN: | FileCheck --check-prefix=CHECK-MAMDGPU-DEBUGGER-ABI-1-0 %s
// CHECK-MAMDGPU-DEBUGGER-ABI-1-0: "-target-feature" "+amdgpu-debugger-insert-nops" "-target-feature" "+amdgpu-debugger-emit-prologue" // CHECK-MAMDGPU-DEBUGGER-ABI-1-0: the clang compiler does not support '-mamdgpu-debugger-abi=1.0'
kzhuravlUnsubmitted
Not Done
ReplyInline Actions

I do not see this prefix in the run line?

kzhuravl: I do not see this prefix in the run line?
// RUN: %clang -### -target amdgcn -mcpu=gfx700 -mcode-object-v3 %s 2>&1 | FileCheck --check-prefix=CODE-OBJECT-V3 %s // RUN: %clang -### -target amdgcn -mcpu=gfx700 -mcode-object-v3 %s 2>&1 | FileCheck --check-prefix=CODE-OBJECT-V3 %s
// CODE-OBJECT-V3: "-target-feature" "+code-object-v3" // CODE-OBJECT-V3: "-target-feature" "+code-object-v3"
// RUN: %clang -### -target amdgcn -mcpu=gfx700 -mno-code-object-v3 %s 2>&1 | FileCheck --check-prefix=NO-CODE-OBJECT-V3 %s // RUN: %clang -### -target amdgcn -mcpu=gfx700 -mno-code-object-v3 %s 2>&1 | FileCheck --check-prefix=NO-CODE-OBJECT-V3 %s
// NO-CODE-OBJECT-V3: "-target-feature" "-code-object-v3" // NO-CODE-OBJECT-V3: "-target-feature" "-code-object-v3"
// RUN: %clang -### -target amdgcn -mcpu=gfx700 -mxnack %s 2>&1 | FileCheck --check-prefix=XNACK %s // RUN: %clang -### -target amdgcn -mcpu=gfx700 -mxnack %s 2>&1 | FileCheck --check-prefix=XNACK %s
Show All 10 Lines