This is an archive of the discontinued LLVM Phabricator instance.

Differential D58289

[clang] Only provide C11 features in <float.h> starting with C++17
ClosedPublic

Authored by ldionne on Feb 15 2019, 9:40 AM.

Details

Reviewers
jfb
eli.friedman
efriedma
Commits
rGc2d95792d64b: [clang] Only provide C11 features in <float.h> starting with C++17
rC354691: [clang] Only provide C11 features in <float.h> starting with C++17
rL354691: [clang] Only provide C11 features in <float.h> starting with C++17
Summary

In r353970, I enabled those features in C++11 and above. To be strictly
conforming, those features should only be enabled in C++17 and above.

Diff Detail

Repository
rL LLVM

Event Timeline

ldionne created this revision.Feb 15 2019, 9:40 AM
Herald added subscribers: libcxx-commits, dexonsmith, jkorous. · View Herald TranscriptFeb 15 2019, 9:41 AM
Harbormaster completed remote builds in B28197: Diff 187032.Feb 15 2019, 9:41 AM
ldionne changed the repository for this revision from rCXX libc++ to rC Clang.Feb 15 2019, 9:42 AM
ldionne edited subscribers, added: cfe-commits; removed: libcxx-commits.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2019, 9:42 AM
efriedma accepted this revision.Feb 15 2019, 6:27 PM
efriedma added a subscriber: efriedma.

LGTM

This revision is now accepted and ready to land.Feb 15 2019, 6:27 PM
Closed by commit rL354691: [clang] Only provide C11 features in <float.h> starting with C++17 (authored by ldionne). · Explain WhyFeb 22 2019, 12:48 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 22 2019, 12:48 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
cfe/
trunk/
lib/
Headers/
4 lines
test/
Headers/
4 lines

Diff 187972

cfe/trunk/lib/Headers/float.h

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines
# undef DBL_MAX # undef DBL_MAX
# undef LDBL_MAX # undef LDBL_MAX
# undef FLT_EPSILON # undef FLT_EPSILON
# undef DBL_EPSILON # undef DBL_EPSILON
# undef LDBL_EPSILON # undef LDBL_EPSILON
# undef FLT_MIN # undef FLT_MIN
# undef DBL_MIN # undef DBL_MIN
# undef LDBL_MIN # undef LDBL_MIN
# if __STDC_VERSION__ >= 201112L || !defined(__STRICT_ANSI__) || __cplusplus >= 201103L # if __STDC_VERSION__ >= 201112L || !defined(__STRICT_ANSI__) || __cplusplus >= 201703L
# undef FLT_TRUE_MIN # undef FLT_TRUE_MIN
# undef DBL_TRUE_MIN # undef DBL_TRUE_MIN
# undef LDBL_TRUE_MIN # undef LDBL_TRUE_MIN
# undef FLT_DECIMAL_DIG # undef FLT_DECIMAL_DIG
# undef DBL_DECIMAL_DIG # undef DBL_DECIMAL_DIG
# undef LDBL_DECIMAL_DIG # undef LDBL_DECIMAL_DIG
# undef FLT_HAS_SUBNORM # undef FLT_HAS_SUBNORM
# undef DBL_HAS_SUBNORM # undef DBL_HAS_SUBNORM
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
#define FLT_EPSILON __FLT_EPSILON__ #define FLT_EPSILON __FLT_EPSILON__
#define DBL_EPSILON __DBL_EPSILON__ #define DBL_EPSILON __DBL_EPSILON__
#define LDBL_EPSILON __LDBL_EPSILON__ #define LDBL_EPSILON __LDBL_EPSILON__
#define FLT_MIN __FLT_MIN__ #define FLT_MIN __FLT_MIN__
#define DBL_MIN __DBL_MIN__ #define DBL_MIN __DBL_MIN__
#define LDBL_MIN __LDBL_MIN__ #define LDBL_MIN __LDBL_MIN__
#if __STDC_VERSION__ >= 201112L || !defined(__STRICT_ANSI__) || __cplusplus >= 201103L #if __STDC_VERSION__ >= 201112L || !defined(__STRICT_ANSI__) || __cplusplus >= 201703L
# define FLT_TRUE_MIN __FLT_DENORM_MIN__ # define FLT_TRUE_MIN __FLT_DENORM_MIN__
# define DBL_TRUE_MIN __DBL_DENORM_MIN__ # define DBL_TRUE_MIN __DBL_DENORM_MIN__
# define LDBL_TRUE_MIN __LDBL_DENORM_MIN__ # define LDBL_TRUE_MIN __LDBL_DENORM_MIN__
# define FLT_DECIMAL_DIG __FLT_DECIMAL_DIG__ # define FLT_DECIMAL_DIG __FLT_DECIMAL_DIG__
# define DBL_DECIMAL_DIG __DBL_DECIMAL_DIG__ # define DBL_DECIMAL_DIG __DBL_DECIMAL_DIG__
# define LDBL_DECIMAL_DIG __LDBL_DECIMAL_DIG__ # define LDBL_DECIMAL_DIG __LDBL_DECIMAL_DIG__
# define FLT_HAS_SUBNORM __FLT_HAS_DENORM__ # define FLT_HAS_SUBNORM __FLT_HAS_DENORM__
# define DBL_HAS_SUBNORM __DBL_HAS_DENORM__ # define DBL_HAS_SUBNORM __DBL_HAS_DENORM__
Show All 18 Lines

cfe/trunk/test/Headers/float.c

Show All 39 Lines
#elif LDBL_MANT_DIG < 2 #elif LDBL_MANT_DIG < 2
#error "Mandatory macro LDBL_MANT_DIG is invalid." #error "Mandatory macro LDBL_MANT_DIG is invalid."
#endif #endif
#if ((FLT_MANT_DIG > DBL_MANT_DIG) || (DBL_MANT_DIG > LDBL_MANT_DIG)) #if ((FLT_MANT_DIG > DBL_MANT_DIG) || (DBL_MANT_DIG > LDBL_MANT_DIG))
#error "Mandatory macros {FLT,DBL,LDBL}_MANT_DIG are invalid." #error "Mandatory macros {FLT,DBL,LDBL}_MANT_DIG are invalid."
#endif #endif
#if __STDC_VERSION__ >= 201112L || !defined(__STRICT_ANSI__) || __cplusplus >= 201103L #if __STDC_VERSION__ >= 201112L || !defined(__STRICT_ANSI__) || __cplusplus >= 201703L
#ifndef FLT_DECIMAL_DIG #ifndef FLT_DECIMAL_DIG
#error "Mandatory macro FLT_DECIMAL_DIG is missing." #error "Mandatory macro FLT_DECIMAL_DIG is missing."
#elif FLT_DECIMAL_DIG < 6 #elif FLT_DECIMAL_DIG < 6
#error "Mandatory macro FLT_DECIMAL_DIG is invalid." #error "Mandatory macro FLT_DECIMAL_DIG is invalid."
#endif #endif
#ifndef DBL_DECIMAL_DIG #ifndef DBL_DECIMAL_DIG
#error "Mandatory macro DBL_DECIMAL_DIG is missing." #error "Mandatory macro DBL_DECIMAL_DIG is missing."
#elif DBL_DECIMAL_DIG < 10 #elif DBL_DECIMAL_DIG < 10
▲ Show 20 Lines • Show All 153 Lines • ▼ Show 20 Lines
/* Internal consistency checks */ /* Internal consistency checks */
_Static_assert(FLT_RADIX == __FLT_RADIX__, ""); _Static_assert(FLT_RADIX == __FLT_RADIX__, "");
_Static_assert(FLT_MANT_DIG == __FLT_MANT_DIG__, ""); _Static_assert(FLT_MANT_DIG == __FLT_MANT_DIG__, "");
_Static_assert(DBL_MANT_DIG == __DBL_MANT_DIG__, ""); _Static_assert(DBL_MANT_DIG == __DBL_MANT_DIG__, "");
_Static_assert(LDBL_MANT_DIG == __LDBL_MANT_DIG__, ""); _Static_assert(LDBL_MANT_DIG == __LDBL_MANT_DIG__, "");
#if __STDC_VERSION__ >= 201112L || !defined(__STRICT_ANSI__) || __cplusplus >= 201103L #if __STDC_VERSION__ >= 201112L || !defined(__STRICT_ANSI__) || __cplusplus >= 201703L
_Static_assert(FLT_DECIMAL_DIG == __FLT_DECIMAL_DIG__, ""); _Static_assert(FLT_DECIMAL_DIG == __FLT_DECIMAL_DIG__, "");
_Static_assert(DBL_DECIMAL_DIG == __DBL_DECIMAL_DIG__, ""); _Static_assert(DBL_DECIMAL_DIG == __DBL_DECIMAL_DIG__, "");
_Static_assert(LDBL_DECIMAL_DIG == __LDBL_DECIMAL_DIG__, ""); _Static_assert(LDBL_DECIMAL_DIG == __LDBL_DECIMAL_DIG__, "");
#endif #endif
#if __STDC_VERSION__ >= 199901L || !defined(__STRICT_ANSI__) || __cplusplus >= 201103L #if __STDC_VERSION__ >= 199901L || !defined(__STRICT_ANSI__) || __cplusplus >= 201103L
_Static_assert(DECIMAL_DIG == __DECIMAL_DIG__, ""); _Static_assert(DECIMAL_DIG == __DECIMAL_DIG__, "");
#endif #endif
Show All 20 Lines