Deserialize Clang module search path from DWARF

[aprantl]

Summary

This is an unfinished patch I'm working on that Raphael may find interesting. Posting to get early feedback and to avoid stepping on each others' toes.

rdar://problem/47970144

[teemperor]

+1. That's a cleaner version of what I had to do in D58125, so feel free to commit when done. The code is similar enough that rebasing my patch on top shouldn't take too much time.

include/lldb/Symbol/SourceModule.h

13

Should also include lldb/Utility/ConstString.h otherwise this breaks the module build.

source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp

320

path is unused.

[JDevlieghere]

The change itself looks fine, just a few nits inline.

include/lldb/Symbol/SourceModule.h

24

Can you run clang-format on this? (It will add // namespace lldb_private here.)

source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp

266

Can we make this i?

source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

941

Can we use a StringRef here?

[shafik]

source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp

266

Or perhaps path_index

[aprantl]

Almost final version. There's a silly bug that prevents the C Darwin module to be loaded now that I haven't been able to track down yet.

[aprantl]

I think the problem was that I had an incompletely built libcxx in my build directory.

[stella.stamenova]

This looks to have broken the windows build:

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/1665

[aprantl]

I attempted to fix it in r353971, but I'm not sure.