Page MenuHomePhabricator

GlobalISel: Implement widenScalar for g_extract scalar results
ClosedPublic

Authored by arsenm on Feb 11 2019, 2:47 PM.

Diff Detail

Event Timeline

arsenm created this revision.Feb 11 2019, 2:47 PM
aemerson accepted this revision.Feb 18 2019, 1:58 PM

LGTM.

lib/CodeGen/GlobalISel/MachineIRBuilder.cpp
474

Out of curiosity, why does this need changing?

This revision is now accepted and ready to land.Feb 18 2019, 1:58 PM
arsenm marked an inline comment as done.Feb 18 2019, 2:11 PM
arsenm added inline comments.
lib/CodeGen/GlobalISel/MachineIRBuilder.cpp
474

A random assortment of functions in MachineIRBuilder don't use SrcOp/DstOp, so this makes it consistent with the other operations. I can commit this separately

arsenm closed this revision.Feb 18 2019, 2:39 PM

r354292-354293