[lldb] [test] Skip lldb-mi test if LLDB_DISABLE_PYTHON is used

[mgorny]

Summary

Skip running lldb-mi tests when Python support is disabled. This causes
lldb-mi to unconditionally fail, and therefore all the relevant tests
fail as well.

[labath]

Instead of adding REQUIRES: lldb-mi to every test, it would be better to create an appropriate lit.local.cfg in the lit/tools/lldb-mi folder. I think something like:

if not "lldb-mi" in config.available_features:
  config.unsupported = True

ought to do the trick.

[mgorny]

Used lit.local.cfg.

lldb/lit/helper/toolchain.py

primary_tools = [
         'lldb-instr',
         ToolSubst('%build',
                   command="'" + sys.executable + "'",
                   extra_args=build_script_args)
         ]
 
     llvm_config.add_tool_substitutions(primary_tools,
                                        [config.lldb_tools_dir])
-    if lldbmi.was_resolved:
+    # lldb-mi always fails without Python support
+    if lldbmi.was_resolved and not config.lldb_disable_python:
         config.available_features.add('lldb-mi')
 
 def _use_msvc_substitutions(config):
     # If running from a Visual Studio Command prompt (e.g. vcvars), this will
     # detect the include and lib paths, and find cl.exe and link.exe and create
     # substitutions for each of them that explicitly specify /I and /L paths
     cl = lit.util.which('cl')
     link = lit.util.which('link')

lldb/lit/lit.site.cfg.py.in

 # Since it comes from the command line, it may have backslashes which
 # should not need to be escaped.
 config.lldb_lit_tools_dir = r"@LLDB_LIT_TOOLS_DIR@"
 config.target_triple = "@TARGET_TRIPLE@"
 config.python_executable = "@PYTHON_EXECUTABLE@"
 config.have_zlib = @LLVM_ENABLE_ZLIB@
 config.host_triple = "@LLVM_HOST_TRIPLE@"
 config.lldb_bitness = 64 if @LLDB_IS_64_BITS@ else 32
+config.lldb_disable_python = @LLDB_DISABLE_PYTHON@
 
 # Support substitution of the tools and libs dirs with user parameters. This is
 # used when we can't determine the tool dir at configuration time.
 try:
     config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
     config.llvm_libs_dir = config.llvm_libs_dir % lit_config.params
     config.llvm_shlib_dir = config.llvm_shlib_dir % lit_config.params
     config.lldb_libs_dir = config.lldb_libs_dir % lit_config.params

lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test

 # XFAIL: system-windows
 # -> llvm.org/pr24452
+# REQUIRES: lldb-mi
 #
 # RUN: %clang -o %t %p/inputs/break-insert-pending.c -g
 # RUN: %lldbmi %t < %s | FileCheck %s
 
 # Test for enabling pending breakpoints globally
 
 -break-insert printf
 # CHECK: ^error,msg="Command 'break-insert'. Breakpoint location 'printf' not found

lldb/lit/tools/lldb-mi/breakpoint/break-insert.test

+# REQUIRES: lldb-mi
 # RUN: %build %p/inputs/break-insert.c --nodefaultlib -o a.exe
 # RUN: %lldbmi < %s | FileCheck %s
 
 # Test that a breakpoint can be inserted before creating a target.
 
 -break-insert breakpoint
 # CHECK: ^done,bkpt={number="1"
 
 -file-exec-and-symbols a.exe
 # CHECK: ^done
 
 -exec-run
 # CHECK: ^running
 # CHECK: *stopped,reason="breakpoint-hit"
 

lldb/lit/tools/lldb-mi/data/data-info-line.test

+# REQUIRES: lldb-mi
 # RUN: %build %p/inputs/data-info-line.c --nodefaultlib -o %t
 # RUN: %lldbmi %t < %s | FileCheck %s
 
 # Test lldb-mi -data-info-line command.
 
 # Check that we have a valid target created via '%lldbmi %t'.
 # CHECK: ^done
 

lldb/lit/tools/lldb-mi/exec/exec-continue.test

+# REQUIRES: lldb-mi
 # RUN: %build %p/inputs/main.c --nodefaultlib -o %t
 # RUN: %lldbmi %t < %s | FileCheck %s
 
 # Test lldb-mi -exec-continue command.
 
 # Check that we have a valid target created via '%lldbmi %t'.
 # CHECK: ^done
 

lldb/lit/tools/lldb-mi/exec/exec-finish.test

+# REQUIRES: lldb-mi
 # RUN: %build %p/inputs/main.c -o %t
 # RUN: %lldbmi %t < %s | FileCheck %s
 
 # Test lldb-mi -exec-finish command.
 
 # Check that we have a valid target created via '%lldbmi %t'.
 # CHECK: ^done
 

lldb/lit/tools/lldb-mi/exec/exec-interrupt.test

+# REQUIRES: lldb-mi
 # RUN: %build %p/inputs/main.c --nodefaultlib -o %t
 # RUN: %lldbmi %t < %s | FileCheck %s
 
 # Test lldb-mi -exec-interrupt command.
 
 # Check that we have a valid target created via '%lldbmi %t'.
 # CHECK: ^done
 

lldb/lit/tools/lldb-mi/exec/exec-next-instruction.test

+# REQUIRES: lldb-mi
 # RUN: %build %p/inputs/main.c --nodefaultlib -o %t
 # RUN: %lldbmi %t < %s | FileCheck %s
 
 # Test lldb-mi -exec-next-instruction command.
 
 # Check that we have a valid target created via '%lldbmi %t'.
 # CHECK: ^done
 

lldb/lit/tools/lldb-mi/exec/exec-next.test

+# REQUIRES: lldb-mi
 # RUN: %build %p/inputs/main.c --nodefaultlib -o %t
 # RUN: %lldbmi %t < %s | FileCheck %s
 
 # Test lldb-mi -exec-next command.
 
 # Check that we have a valid target created via '%lldbmi %t'.
 # CHECK: ^done
 

lldb/lit/tools/lldb-mi/exec/exec-run-wrong-binary.test

+# REQUIRES: lldb-mi
 # RUN: %lldbmi < %s | FileCheck %s
 
 # Test that -exec-run command won't hang in case of wrong name of binary file.
 
 -file-exec-and-symbols name.exe
 # CHECK: ^error,msg="Command 'file-exec-and-symbols'. Target binary 'name.exe' is invalid.

lldb/lit/tools/lldb-mi/exec/exec-step-instruction.test

+# REQUIRES: lldb-mi
 # RUN: %build %p/inputs/main.c --nodefaultlib -o %t
 # RUN: %lldbmi %t < %s | FileCheck %s
 
 # Test lldb-mi -exec-step-instruction command.
 
 # Check that we have a valid target created via '%lldbmi %t'.
 # CHECK: ^done
 

lldb/lit/tools/lldb-mi/exec/exec-step.test

+# REQUIRES: lldb-mi
 # RUN: %build %p/inputs/main.c --nodefaultlib -o %t
 # RUN: %lldbmi %t < %s | FileCheck %s
 
 # Test lldb-mi -exec-step command.
 
 # Check that we have a valid target created via '%lldbmi %t'.
 # CHECK: ^done
 

lldb/lit/tools/lldb-mi/symbol/symbol-list-lines.test

+# REQUIRES: lldb-mi
 # RUN: %build %p/inputs/main.c %p/inputs/symbol-list-lines.c %p/inputs/list-lines-helper.c --nodefaultlib -o %t
 # RUN: %lldbmi %t < %s | FileCheck %s
 
 # Test lldb-mi -symbol-list-lines command.
 
 # Check that we have a valid target created via '%lldbmi %t'.
 # CHECK: ^done
 

lldb/lit/tools/lldb-mi/target/target-select-so-path.test

+# REQUIRES: lldb-mi
 # UNSUPPORTED: system-windows, system-darwin
 #
 # RUN: %clang -o %t %p/inputs/main.c -g
 # RUN: %python %p/inputs/target-select-so-path.py "%debugserver" "%lldbmi %t" %s
 
 # Test that -target-select command can hook up a path
 # added by gdb-set solib-search-path.