Fix Die() after pthread_exit call on macOS

[yuri]

Summary

Scoped interceptor should not be used when calling real pthread_exit().
On macOS C++ destructors are not called by pthread_exit(), and later check for empty thread ignore set fails.

Patch by Yuri Per.

[vitalybuka]

lib/tsan/rtl/tsan_interceptors.cc

1054

Why do we need SCOPED_INTERCEPTOR like this if we do nothing inside of its scope?

BTW. I am trying to remove it completely as Dmitry suggested r353552

[yuri]

lib/tsan/rtl/tsan_interceptors.cc

1054

I copied this construction from other place in the same file. I guess it is intended for logging. There are several interceptors (for example, longjmp) that has the same structure. Moreover, In the next patch CHECK using 'thr' will be added into this scope.

[vitalybuka]

LGTM
I'll commit it.

lib/tsan/rtl/tsan_interceptors.cc

TSAN_INTERCEPTOR(int, pthread_detach, void *th) {
   int res = REAL(pthread_detach)(th);
   if (res == 0) {
     ThreadDetach(thr, pc, tid);
   }
   return res;
 }
 
 TSAN_INTERCEPTOR(void, pthread_exit, void *retval) {
+  {
+    SCOPED_INTERCEPTOR_RAW(pthread_exit, retval);
+  }
   REAL(pthread_exit)(retval);
 }
 
 #if SANITIZER_LINUX
 TSAN_INTERCEPTOR(int, pthread_tryjoin_np, void *th, void **ret) {
   SCOPED_TSAN_INTERCEPTOR(pthread_tryjoin_np, th, ret);
   int tid = ThreadTid(thr, pc, (uptr)th);
   ThreadIgnoreBegin(thr, pc);