User Details
- User Since
- Nov 14 2018, 3:36 AM (188 w, 4 d)
Apr 16 2020
Added @skipIfWindows
I don't believe this test will pass on windows, because of the different path styles. I don't think it's possible to meaningfully test this on windows, as it requires the path in the core file to match a host path. So, I think you can just slap @skipIfWindows on the test.
@labath, please take a look
Apr 6 2020
Do not depend on existance of /bin/sh anymore
Build failure is a bug of tidy script and is not caused by the patch itself.
/mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/lldb/source/Target/RemoteAwarePlatform.cpp:9:10: error: 'lldb/Target/RemoteAwarePlatform.h' file not found [clang-diagnostic-error] #include "lldb/Target/RemoteAwarePlatform.h" ^
Aug 3 2019
Mar 25 2019
Feb 25 2019
Feb 20 2019
If everything is OK, can you commit this patch?
Feb 19 2019
Disable tests on tvOS and watchOS
Feb 18 2019
Do not include <ucontext.h> and declare getcontext/setcontext manually
Feb 15 2019
Added
#if !SANITIZER_WATCHOS && !SANITIZER_TVOS
around swapcontext interceptor
Feb 14 2019
Cleanup tests
Feb 13 2019
Patch with context
Feb 12 2019
@lei, please help to investigate what happened in http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/11413
Final patch (macOS support): D58110
Add more calls of cur_thread_init()
Feb 11 2019
Patch with in_symbolizer() function: D58104
Feb 10 2019
Rebased on current trunk
Feb 9 2019
Feb 8 2019
Fix for macOS is in D57963
- Replaced cur_thread1 with ThreadState::current
- Removed cur_thread_fast() and replaced calls with cur_thread()
- Added cur_thread_init()
Feb 7 2019
Can someone with access to ppc64be system help to investigate the issue?
Rebased on current trunk
Next patch (performance optimizations): D57882
Feb 6 2019
One more patch (pthread_exit): D57876
More detailed comment
Jan 21 2019
Hi Dmitry,
Now, when all performance issues are resolved, what else should be done to complete the review?
Jan 11 2019
I have found out which optimization is applied by gcc but not by clang and did it manually. Executions times for new version:
Optimized MemoryAccessImpl1()
Jan 8 2019
Jan 7 2019
I improved test execution time. On my system I got following execution times (compared to original version of code):
Improved performance
Dec 20 2018
Fix typo
- introduce ThreadType enum
- cleanup internal interfaces
- add pthread_exit() interceptor
- more tests
Dec 18 2018
Please check if adding __attribute__((always_inline)) for start_switch_fiber() and finish_switch_fiber() helps
Dec 17 2018
- By default sync fibers with each other on switch
- Faster cur_thread(), no visible difference in benchmark results
- Moved implementation to tsan_rtl_thread.cc
Dec 11 2018
Problem solved differently in D54889
Dec 10 2018
- Temporary switch into fiber context for start and stop instead of avoiding HACKY_CALL
- Minimized perfomance impact of cur_thread() change
- Added (currently unused) flags to _tsan_create_fiber() and _tsan_switch_to_fiber()
Hi Dmitry,
I will try to answer your questions
Dec 3 2018
- Excluded macOS support in order to reduce patch size
- Added comment in tsan_interface.h
- Added tests
Nov 27 2018
Nov 26 2018
Nov 22 2018
I have working implemented of fibers (coroutines) support for thread sanitizer.
Taking in the account that fibers are supported by address sanitizer, support in thread sanitizer may be useful as well.
Nov 21 2018
Improved tests
Nov 20 2018
Added tests and fixed code, now it really works