Page MenuHomePhabricator

[AST] Fix structural inequivalence of operators
ClosedPublic

Authored by martong on Feb 7 2019, 9:22 AM.

Diff Detail

Repository
rC Clang

Event Timeline

martong created this revision.Feb 7 2019, 9:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2019, 9:22 AM
a_sidorin accepted this revision.Feb 7 2019, 3:25 PM

Looks good, thanks!

This revision is now accepted and ready to land.Feb 7 2019, 3:25 PM
shafik added inline comments.Feb 7 2019, 5:25 PM
unittests/AST/StructuralEquivalenceTest.cpp
251

Curious, is this test just for completeness or is this somehow related to the overloaded operator check?

martong marked 2 inline comments as done.Feb 8 2019, 12:23 AM
martong added inline comments.
unittests/AST/StructuralEquivalenceTest.cpp
251

This is just for the sake of completeness. Operators and ctor/dtor do not have regular names with IdentifierInfo. (See the DeclarationName class for details.)

This revision was automatically updated to reflect the committed changes.
martong marked an inline comment as done.