gn build: Make check-{clang,lld,llvm} pass on FreeBSD.

[pcc]

Summary

Mostly achieved by assuming that anything that isn't Win or Mac is ELF,
which seems reasonable enough for now.

[thakis]

Nice!

[pcc]

With a few tweaks check-llvm passes as well. Still looks good?

[thakis]

Yup!

Kind of makes me wish I had already done the plugin() / plugin_host() from TODO.txt, but oh well.

llvm/trunk/utils/gn/secondary/clang/tools/libclang/BUILD.gn

 import("//clang/lib/ARCMigrate/enable.gni")
 import("//llvm/version.gni")
 
 # This build file is just enough to get check-clang to pass, it's missing
 # several things from the CMake build:
 # - linking in clangTidyPlugin and clangIncludeFixerPlugin from
 #   clang-tools-extra (which doesn't have any GN build files yet)
 # - using libclang.exports
 # - a build target copying the Python bindings
 # - the GN linux build always builds without -fPIC (as if LLVM_ENABLE_PIC=OFF
 #   in the CMake build), so libclang is always a static library on linux
 # - the GN build doesn't have LIBCLANG_BUILD_STATIC
 
 libclang_target_type = "shared_library"
-if (host_os == "linux") {
-  # Linux needs -fPIC to build shared libs but they aren't on by default.
+if (host_os != "win" && host_os != "mac") {
+  # ELF targets need -fPIC to build shared libs but they aren't on by default.
   # For now, make libclang a static lib there.
   libclang_target_type = "static_library"
 }
 
 target(libclang_target_type, "libclang") {
   configs += [ "//llvm/utils/gn/build:clang_code" ]
   deps = [
     "//clang/include/clang/Config",

llvm/trunk/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn

values += [
       "HAVE_ZLIB_H=1",
       "HAVE__CHSIZE_S=",
       "HAVE__UNWIND_BACKTRACE=1",
       "stricmp=",
       "strdup=",
     ]
   }
 
-  if (current_os == "linux" || current_os == "android") {
-    values += [ "LTDL_SHLIB_EXT=.so" ]
-  } else if (current_os == "mac") {
+  if (current_os == "mac") {
     values += [ "LTDL_SHLIB_EXT=.dylib" ]
   } else if (current_os == "win") {
     values += [ "LTDL_SHLIB_EXT=.dll" ]
+  } else {
+    values += [ "LTDL_SHLIB_EXT=.so" ]
   }
 
   if (llvm_enable_libedit) {
     values += [ "HAVE_LIBEDIT=1" ]
   } else {
     values += [ "HAVE_LIBEDIT=" ]
   }
 

llvm/trunk/utils/gn/secondary/llvm/lib/Transforms/Hello/BUILD.gn

 assert(host_os != "win", "loadable modules not supported on win")
 
 loadable_module("Hello") {
   output_name = "LLVMHello"
   deps = [
     # LLVMHello doesn't want to link in any LLVM code, it just
     # needs its headers.
     "//llvm/include/llvm/IR:public_tablegen",
   ]
   sources = [
     "Hello.cpp",
   ]
 
-  if (host_os == "linux") {
+  if (host_os != "mac" && host_os != "win") {
     # The GN build currently doesn't globally pass -fPIC, but that's
-    # needed for building .so files on Linux.  Just pass it manually
+    # needed for building .so files on ELF.  Just pass it manually
     # for loadable_modules for now.
     cflags = [ "-fPIC" ]
   }
 
   # FIXME: Use Hello.exports to remove all exports.
 }

llvm/trunk/utils/gn/secondary/llvm/test/BUILD.gn

write_lit_config("lit_site_cfg") {
   ]
 
   if (host_cpu == "x64") {
     extra_values += [ "HOST_ARCH=x86_64" ]
   } else {
     assert(false, "unimplemented host_cpu " + host_cpu)
   }
 
+  if (host_os == "win") {
+    extra_values += [ "EXEEXT=.exe" ]
+  } else {
+    extra_values += [ "EXEEXT=" ]
+  }
+
   if (host_os == "mac") {
-    extra_values += [
-      "EXEEXT=",
-      "HOST_OS=Darwin",
-      "SHLIBEXT=.dylib",
-    ]
+    extra_values += [ "SHLIBEXT=.dylib" ]
+  } else if (host_os == "win") {
+    extra_values += [ "SHLIBEXT=.dll" ]
+  } else {
+    extra_values += [ "SHLIBEXT=.so" ]
+  }
+
+  if (host_os == "freebsd") {
+    extra_values += [ "HOST_OS=FreeBSD" ]
+  } else if (host_os == "mac") {
+    extra_values += [ "HOST_OS=Darwin" ]
   } else if (host_os == "linux") {
-    extra_values += [
-      "EXEEXT=",
-      "HOST_OS=Linux",
-      "SHLIBEXT=.so",
-    ]
+    extra_values += [ "HOST_OS=Linux" ]
   } else if (host_os == "win") {
-    extra_values += [
-      "EXEEXT=.exe",
-      "HOST_OS=Windows",
-      "SHLIBEXT=.dll",
-    ]
+    extra_values += [ "HOST_OS=Windows" ]
   } else {
     assert(false, "unsupported host_os " + host_os)
   }
   if (host_os == "linux") {
     # lit.cfg.py's have_ld_plugin_support() checks for "gold" in --version,
     # so just claim that ld is gold on Linux.  The function also checks if
     # LLVMgold.so exists, but since that target isn't hooked up yet in the GN
     # build the LLVMgold.so tests currently don't run anywhere in the GN build.

llvm/trunk/utils/gn/secondary/llvm/tools/bugpoint-passes/BUILD.gn

 assert(host_os != "win", "loadable modules not supported on win")
 
 loadable_module("bugpoint-passes") {
   output_name = "BugpointPasses"
   deps = [
     # BugpointPasses doesn't want to link in any LLVM code, it just
     # needs its headers.
     "//llvm/include/llvm/IR:public_tablegen",
   ]
   sources = [
     "TestPasses.cpp",
   ]
 
-  if (host_os == "linux") {
+  if (host_os != "mac" && host_os != "win") {
     # The GN build currently doesn't globally pass -fPIC, but that's
-    # needed for building .so files on Linux.  Just pass it manually
+    # needed for building .so files on ELF.  Just pass it manually
     # for loadable_modules for now.
     cflags = [ "-fPIC" ]
   }
 
   # FIXME: Use bugpoint.exports to remove all exports.
 }

llvm/trunk/utils/gn/secondary/llvm/tools/bugpoint/BUILD.gn

sources = [
     "Miscompilation.cpp",
     "OptimizerDriver.cpp",
     "ToolRunner.cpp",
     "bugpoint.cpp",
   ]
 
   # Support plugins.
   # FIXME: Disable dead stripping once other binaries are dead-stripped.
-  if (host_os == "linux") {
+  if (host_os != "mac" && host_os != "win") {
     # Make sure bugpoint plugins can access bugpoint's symbols.
     # Corresponds to export_executable_symbols() in cmake.
     ldflags = [ "-rdynamic" ]
   }
 }

llvm/trunk/utils/gn/secondary/llvm/tools/llc/BUILD.gn

deps = [
     "//llvm/lib/Transforms/Vectorize",
   ]
   sources = [
     "llc.cpp",
   ]
 
   # Support plugins.
   # FIXME: Disable dead stripping once other binaries are dead-stripped.
-  if (host_os == "linux") {
+  if (host_os != "mac" && host_os != "win") {
     # Corresponds to export_executable_symbols() in cmake.
     ldflags = [ "-rdynamic" ]
   }
 }

llvm/trunk/utils/gn/secondary/llvm/tools/lli/BUILD.gn

deps = [
     "//llvm/lib/Target",
     "//llvm/lib/Target:NativeTarget",
     "//llvm/lib/Transforms/Instrumentation",
     "//llvm/lib/Transforms/Utils",
   ]
   sources = [
     "lli.cpp",
   ]
-  if (host_os == "linux") {
+  if (host_os != "mac" && host_os != "win") {
     # Corresponds to export_executable_symbols() in cmake.
     ldflags = [ "-rdynamic" ]
   }
 }

llvm/trunk/utils/gn/secondary/llvm/tools/lto/BUILD.gn

 import("//llvm/version.gni")
 
 lto_target_type = "shared_library"
-if (host_os == "linux") {
-  # Linux needs -fPIC to build shared libs but they aren't on by default.
+if (host_os != "mac" && host_os != "win") {
+  # ELF targets need -fPIC to build shared libs but they aren't on by default.
   # For now, make libclang a static lib there.
   lto_target_type = "static_library"
 }
 
 target(lto_target_type, "lto") {
   output_name = "LTO"
   deps = [
     "//llvm/lib/Bitcode/Reader",

llvm/trunk/utils/gn/secondary/llvm/tools/opt/BUILD.gn

sources = [
     "NewPMDriver.cpp",
     "PassPrinters.cpp",
     "PrintSCC.cpp",
     "opt.cpp",
   ]
 
   # Support plugins.
   # FIXME: Disable dead stripping once other binaries are dead-stripped.
-  if (host_os == "linux") {
+  if (host_os != "mac" && host_os != "win") {
     # Corresponds to export_executable_symbols() in cmake.
     ldflags = [ "-rdynamic" ]
   }
 }

llvm/trunk/utils/gn/secondary/llvm/triples.gni

 if (current_cpu == "x64") {
-  if (current_os == "linux") {
+  if (current_os == "freebsd") {
+    llvm_current_triple = "x86_64-unknown-freebsd"
+  } else if (current_os == "linux") {
     llvm_current_triple = "x86_64-unknown-linux-gnu"
   } else if (current_os == "mac") {
     llvm_current_triple = "x86_64-apple-darwin"
   } else if (current_os == "win") {
     llvm_current_triple = "x86_64-pc-windows"
   }
 } else if (current_cpu == "arm64") {
   if (current_os == "android") {

llvm/trunk/utils/gn/secondary/llvm/unittests/Passes/BUILD.gn

loadable_module("TestPlugin") {
     ]
 
     deps = [
       # TestPlugin doesn't want to link in any LLVM code, it just needs its
       # headers.
       "//llvm/include/llvm/IR:public_tablegen",
     ]
 
-    if (host_os == "linux") {
+    if (host_os != "mac" && host_os != "win") {
       # The GN build currently doesn't globally pass -fPIC, but that's
-      # needed for building .so files on Linux.  Just pass it manually
+      # needed for building .so files on ELF.  Just pass it manually
       # for loadable_modules for now.
       cflags = [ "-fPIC" ]
     }
   }
 }
 
 unittest("PluginsTests") {
   deps = [
unittest("PluginsTests") {
   # If plugins are disabled, this test will disable itself at runtime.
   # Otherwise, reconfiguring with plugins disabled will leave behind a stale
   # executable.
   if (host_os != "win") {
     deps += [ ":TestPlugin" ]
     defines = [ "LLVM_ENABLE_PLUGINS" ]
   }
 
-  if (host_os == "linux") {
+  if (host_os != "mac" && host_os != "win") {
     # Corresponds to export_executable_symbols() in cmake.
     ldflags = [ "-rdynamic" ]
   }
 }

llvm/trunk/utils/gn/secondary/llvm/unittests/Support/DynamicLibrary/BUILD.gn

loadable_module(target_name) {
     # Put plugin next to the unit test executable.
     # This assumes that unittest() puts tests in target_out_dir.
     output_dir = target_out_dir
 
     sources = [
       "PipSqueak.cpp",
     ]
 
-    if (host_os == "linux") {
+    if (host_os != "mac" && host_os != "win") {
       # The GN build currently doesn't globally pass -fPIC, but that's
-      # needed for building .so files on Linux.  Just pass it manually
+      # needed for building .so files on ELF.  Just pass it manually
       # for loadable_modules for now.
       cflags = [ "-fPIC" ]
     }
   }
 }
 
 dynlib_add_module("PipSqueak") {
 }
 
 dynlib_add_module("SecondLib") {
 }
 
 unittest("DynamicLibraryTests") {
   deps = [
     ":PipSqueak",
     ":SecondLib",
     "//llvm/include/llvm/Config:config",
     "//llvm/lib/Support",
   ]
   sources = [
     "DynamicLibraryTest.cpp",
     "ExportedFuncs.cpp",
   ]
 
-  if (host_os == "linux") {
+  if (host_os != "mac" && host_os != "win") {
     # Corresponds to export_executable_symbols() in cmake.
     ldflags = [ "-rdynamic" ]
   }
 }