Page MenuHomePhabricator

[safestack] Explain why tinfo at the end of the buffer
ClosedPublic

Authored by vitalybuka on Feb 6 2019, 4:14 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

vitalybuka created this revision.Feb 6 2019, 4:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2019, 4:15 PM
Herald added subscribers: Restricted Project, jfb. · View Herald Transcript
vitalybuka edited the summary of this revision. (Show Details)Feb 6 2019, 4:18 PM
vitalybuka added reviewers: pcc, eugenis.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2019, 1:30 PM
compiler-rt/lib/safestack/safestack.cc
235 ↗(On Diff #185665)

Shouldn't this be addr+guard?

vitalybuka marked an inline comment as done.Feb 7 2019, 2:13 PM
vitalybuka added inline comments.
compiler-rt/lib/safestack/safestack.cc
235 ↗(On Diff #185665)

unsafe_stack_alloc already does that

vlad.tsyrklevich accepted this revision.Feb 7 2019, 2:15 PM
This revision is now accepted and ready to land.Feb 7 2019, 2:15 PM
vitalybuka updated this revision to Diff 185877.Feb 7 2019, 3:17 PM

do nothing

vitalybuka retitled this revision from [safestack] Simplify tinfo location calculation to [safestack] Explain why tinfo at the end of the buffer.Feb 7 2019, 3:18 PM
vitalybuka edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.