Page MenuHomePhabricator

[opt-viewer] Add --filter option to select remarks for displaying.

Authored by fhahn on Feb 6 2019, 9:30 AM.



This allows limiting the displayed remarks to the ones with names
matching the filter (regular) expression.

Generating html pages for a larger project with optimization remarks can
result in a huge HTML documents and using --filter allows to focus on a
set of interesting remarks.

Diff Detail


Event Timeline

fhahn created this revision.Feb 6 2019, 9:30 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: arphaman. · View Herald Transcript
anemet accepted this revision.Feb 6 2019, 9:44 AM

LGTM with the comment.

347–350 ↗(On Diff #185581)

Mention that it's the pass name that is matched.

This revision is now accepted and ready to land.Feb 6 2019, 9:44 AM
This revision was automatically updated to reflect the committed changes.
fhahn added a comment.Feb 6 2019, 10:45 AM

Thanks Adam. Changed help text to ''Only display remarks from passes matching filter expression' in the committed version.