Page MenuHomePhabricator

Replace uses of %T with %t in from previous frontend test differential
ClosedPublic

Authored by justice_adams on Feb 1 2019, 9:14 AM.

Details

Summary

After committing a change I had made to a few frontend tests, it was pointed out to me that %T is being deprecated in LLVM in favor of %t. This change simply converts usages of %T to %t while maintaining the integrity of the test.

Previous revision where this discussion took place: https://reviews.llvm.org/D50563

Diff Detail

Repository
rL LLVM

Event Timeline

justice_adams created this revision.Feb 1 2019, 9:14 AM

@stella.stamenova These are the changes from our previous discussion regarding the usage of %T

thakis accepted this revision.Feb 1 2019, 9:35 AM

Normally when needing a directory you'd mkdir %t.dir before using it, but since you don't' want the directory to exist here this should be good as-is. Thanks!

This revision is now accepted and ready to land.Feb 1 2019, 9:35 AM

@thakis thanks for the review. I don't have commit access, would you mind committing this for me?

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2019, 3:16 PM

Done, thanks for the patch!

The NetBSD buildbot breaks in these tests now:

http://lab.llvm.org:8011/builders/lldb-amd64-ninja-netbsd8/builds/18721

Both tests break in a similar way:

Command Output (stderr):
--
+ : 'RUN: at line 1'
+ not /home/motus/netbsd8/netbsd8/build/bin/clang -cc1 -internal-isystem /home/motus/netbsd8/netbsd8/build/lib/clang/9.0.0/include -nostdsysteminc -emit-llvm -o /home/motus/netbsd8/netbsd8/build/tools/clang/test/Frontend/Output/output-failures.c.tmp/doesnotexist/somename /home/motus/netbsd8/netbsd8/llvm/tools/clang/test/Frontend/output-failures.c
+ : 'RUN: at line 2'
+ /home/motus/netbsd8/netbsd8/build/bin/FileCheck -check-prefix=OUTPUTFAIL -input-file=/home/motus/netbsd8/netbsd8/build/tools/clang/test/Frontend/Output/output-failures.c.tmp /home/motus/netbsd8/netbsd8/llvm/tools/clang/test/Frontend/output-failures.c
/home/motus/netbsd8/netbsd8/llvm/tools/clang/test/Frontend/output-failures.c:4:16: error: OUTPUTFAIL: expected string not found in input
// OUTPUTFAIL: error: unable to open output file '{{.*}}doesnotexist{{.}}somename': '{{[nN]}}o such file or directory'
               ^
/home/motus/netbsd8/netbsd8/build/tools/clang/test/Frontend/Output/output-failures.c.tmp:1:1: note: scanning from here
error: unable to open output file '/home/motus/netbsd8/netbsd8/build/tools/clang/test/Frontend/Output/output-failures.c.tmp/doesnotexist/somename': 'Not a directory'
^
/home/motus/netbsd8/netbsd8/build/tools/clang/test/Frontend/Output/output-failures.c.tmp:1:86: note: possible intended match here
error: unable to open output file '/home/motus/netbsd8/netbsd8/build/tools/clang/test/Frontend/Output/output-failures.c.tmp/doesnotexist/somename': 'Not a directory'
                                                                                     ^

--

Please fix.

The NetBSD buildbot breaks in these tests now:

Pretty much every bot is red because of this patch (http://lab.llvm.org:8011/one_line_per_build) so yes, please fix.