Page MenuHomePhabricator

justice_adams (Justice Adams)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 9 2018, 5:42 PM (94 w, 4 d)

Recent Activity

Mon, May 4

justice_adams updated the diff for D76863: Fix SelectionDAG Graph Printing on Windows.
  • Fix formatting
Mon, May 4, 9:37 AM · Restricted Project

Sun, May 3

justice_adams updated the diff for D76863: Fix SelectionDAG Graph Printing on Windows.
  • Converted to range-based for loop
Sun, May 3, 4:59 PM · Restricted Project
justice_adams added a comment to D76863: Fix SelectionDAG Graph Printing on Windows.

@rnk Thanks for the suggestions, I've updated it. If it looks good on your end, yes, I would appreciate it if you could commit this for me, I don't have commit access.

Sun, May 3, 4:59 PM · Restricted Project

Apr 30 2020

justice_adams added inline comments to D76863: Fix SelectionDAG Graph Printing on Windows.
Apr 30 2020, 10:41 AM · Restricted Project

Apr 29 2020

justice_adams added a comment to D76863: Fix SelectionDAG Graph Printing on Windows.

@rnk Sorry for the delay, I moved the file path length handling accordingly

Apr 29 2020, 5:50 PM · Restricted Project
justice_adams updated the diff for D76863: Fix SelectionDAG Graph Printing on Windows.
  • moved handling of long paths to createGraphFilename()
Apr 29 2020, 5:50 PM · Restricted Project

Apr 15 2020

justice_adams added a comment to D76863: Fix SelectionDAG Graph Printing on Windows.

@rnk

So, if I want clang to overwrite some file, all I have to do is pass clang -mllvm -view-dag-combine1-dags and I can create a file with a name from the input source? That seems dangerous.

Apr 15 2020, 3:27 PM · Restricted Project

Apr 13 2020

justice_adams added a comment to D76863: Fix SelectionDAG Graph Printing on Windows.

Ping requesting review

Apr 13 2020, 1:35 PM · Restricted Project

Mar 26 2020

justice_adams updated the diff for D76863: Fix SelectionDAG Graph Printing on Windows.
  • removed static declaration from header file
  • cleaned up code according to clang-tidy specifications
Mar 26 2020, 12:29 PM · Restricted Project
justice_adams added reviewers for D76863: Fix SelectionDAG Graph Printing on Windows: bkramer, george.karpenkov, bogner.
Mar 26 2020, 10:18 AM · Restricted Project
justice_adams added a comment to D76863: Fix SelectionDAG Graph Printing on Windows.

I've attached a reproducible.zip folder. To reproduce this bug, unzip the folder and compile multiply.cpp to LLVM IR and then run

Mar 26 2020, 10:17 AM · Restricted Project
justice_adams created D76863: Fix SelectionDAG Graph Printing on Windows.
Mar 26 2020, 9:45 AM · Restricted Project

Feb 24 2020

justice_adams added a comment to D74881: [SelectionDag] Merge constant SDNode arithmetic into foldConstantArithmetic.

@RKSimon Thank you for the review, would you be able to commit this for me? I don't have commit access

Feb 24 2020, 9:53 AM · Restricted Project

Feb 19 2020

justice_adams created D74881: [SelectionDag] Merge constant SDNode arithmetic into foldConstantArithmetic.
Feb 19 2020, 4:42 PM · Restricted Project

Jan 24 2020

justice_adams added a comment to D72870: [SelectionDag] Updated FoldConstantArithmetic method signature in preparation for merge with FoldConstantVectorArithmetic.

Thank you for the review @spatel . I do not have commit access, could you possibly commit this for me?

Jan 24 2020, 8:31 AM · Restricted Project

Jan 23 2020

justice_adams updated the diff for D72870: [SelectionDag] Updated FoldConstantArithmetic method signature in preparation for merge with FoldConstantVectorArithmetic.

@RKSimon I removed the unnecessary braces. Good catch

Jan 23 2020, 2:12 PM · Restricted Project
justice_adams added a comment to D72870: [SelectionDag] Updated FoldConstantArithmetic method signature in preparation for merge with FoldConstantVectorArithmetic.

@spatel My mistake! I have run clang-format on the patch and the diff should be cleaned up

Jan 23 2020, 11:05 AM · Restricted Project
justice_adams updated the diff for D72870: [SelectionDag] Updated FoldConstantArithmetic method signature in preparation for merge with FoldConstantVectorArithmetic.

Ran clang-format on the patch

Jan 23 2020, 11:05 AM · Restricted Project

Jan 16 2020

justice_adams created D72870: [SelectionDag] Updated FoldConstantArithmetic method signature in preparation for merge with FoldConstantVectorArithmetic.
Jan 16 2020, 1:16 PM · Restricted Project

Oct 3 2019

justice_adams accepted D68066: [llvm-objdump] Further rearrange llvm-objdump sections for compatability.
Oct 3 2019, 2:54 PM · Restricted Project
justice_adams added a comment to D68066: [llvm-objdump] Further rearrange llvm-objdump sections for compatability.

@rupprecht Thanks for the explanation, that makes perfect sense. This LGTM (but note that I'm fairly new to the binutils)

Oct 3 2019, 2:53 PM · Restricted Project

Oct 2 2019

justice_adams added a comment to D68066: [llvm-objdump] Further rearrange llvm-objdump sections for compatability.

@rupprecht With most of the lit test adjustments here the only change was the ordering, which makes sense. Could you help me understand why the addition of the various [1-9] style regex expressions were also added to certain tests? Are those just ensuring more verbose matches with FileCheck?

Oct 2 2019, 9:44 PM · Restricted Project

Sep 29 2019

justice_adams added a comment to D68066: [llvm-objdump] Further rearrange llvm-objdump sections for compatability.

@rupprecht A bit of a beginner to LLVM, but why add the suppression for DynamicRelocations when --disassemble is provided?

Sep 29 2019, 7:55 PM · Restricted Project

Sep 12 2019

justice_adams added a comment to D67357: [llvm-objdump] Fix llvm-objdump --all-headers output order.

Thanks for the review all. I don't have commit access, @grimar could you commit this for me?

Sep 12 2019, 9:14 AM · Restricted Project

Sep 11 2019

justice_adams added a comment to D67357: [llvm-objdump] Fix llvm-objdump --all-headers output order.

@grimar my apologies. I reuploaded the patch with more context according to the documentation you linked! Also, made the changes suggested via the comments above

Sep 11 2019, 9:01 AM · Restricted Project
justice_adams updated the diff for D67357: [llvm-objdump] Fix llvm-objdump --all-headers output order.
Sep 11 2019, 8:55 AM · Restricted Project

Sep 10 2019

justice_adams updated the diff for D67357: [llvm-objdump] Fix llvm-objdump --all-headers output order.

Restored check-empty check as suggested by @ychen

Sep 10 2019, 3:52 PM · Restricted Project

Sep 9 2019

justice_adams added a comment to D67357: [llvm-objdump] Fix llvm-objdump --all-headers output order.

Relevant BugZilla Bug: https://bugs.llvm.org/show_bug.cgi?id=41830

Sep 9 2019, 8:39 AM · Restricted Project
justice_adams created D67357: [llvm-objdump] Fix llvm-objdump --all-headers output order.
Sep 9 2019, 8:39 AM · Restricted Project

Feb 1 2019

justice_adams added a comment to D57592: Replace uses of %T with %t in from previous frontend test differential .

@thakis thanks for the review. I don't have commit access, would you mind committing this for me?

Feb 1 2019, 10:45 AM · Restricted Project, Restricted Project
justice_adams added a comment to D57592: Replace uses of %T with %t in from previous frontend test differential .

@stella.stamenova These are the changes from our previous discussion regarding the usage of %T

Feb 1 2019, 9:15 AM · Restricted Project, Restricted Project
justice_adams created D57592: Replace uses of %T with %t in from previous frontend test differential .
Feb 1 2019, 9:14 AM · Restricted Project, Restricted Project

Jan 31 2019

justice_adams added a comment to D50563: Fixed frontend clang tests in windows read-only container.

@stella.stamenova @thakis Thanks for the feedback all, I will go ahead and make this change to the way I'm representing directories, open a new diff for review, and add you as a reviewer.

Jan 31 2019, 5:03 PM · Restricted Project

Jan 24 2019

justice_adams added a comment to D50563: Fixed frontend clang tests in windows read-only container.

@stella.stamenova thanks for the review. I don't have commit access, would you mind committing this for me?

Jan 24 2019, 9:45 AM · Restricted Project

Jan 23 2019

justice_adams added a comment to D50563: Fixed frontend clang tests in windows read-only container.

@stella.stamenova Thanks for the input, what about now?

Jan 23 2019, 3:28 PM · Restricted Project
justice_adams updated the diff for D50563: Fixed frontend clang tests in windows read-only container.
Jan 23 2019, 3:27 PM · Restricted Project
justice_adams added a comment to D50563: Fixed frontend clang tests in windows read-only container.

@stella.stamenova Good suggestion, I think you are right. I have updated the diff to use %t, that way any end-users can control the way their lit test work in a read-only mount by simply altering the test_exec_root in their config

Jan 23 2019, 1:46 PM · Restricted Project
justice_adams updated the diff for D50563: Fixed frontend clang tests in windows read-only container.
Jan 23 2019, 1:42 PM · Restricted Project

Dec 13 2018

justice_adams added reviewers for D50563: Fixed frontend clang tests in windows read-only container: zturner, MatzeB, stella.stamenova.
Dec 13 2018, 9:42 AM · Restricted Project
justice_adams removed a reviewer for D50563: Fixed frontend clang tests in windows read-only container: cfe-commits.
Dec 13 2018, 9:36 AM · Restricted Project
justice_adams updated the summary of D50563: Fixed frontend clang tests in windows read-only container.
Dec 13 2018, 8:52 AM · Restricted Project

Dec 12 2018

justice_adams added a comment to D50563: Fixed frontend clang tests in windows read-only container.

@cfe-commits Re-pinging this group to request a review on this patch

Dec 12 2018, 5:26 PM · Restricted Project

Oct 22 2018

justice_adams added a comment to D50563: Fixed frontend clang tests in windows read-only container.

@cfe-commits ping requesting a review on this patch

Oct 22 2018, 9:56 AM · Restricted Project

Aug 14 2018

justice_adams added reviewers for D50563: Fixed frontend clang tests in windows read-only container: rsmith, cfe-commits.
Aug 14 2018, 8:24 AM · Restricted Project

Aug 10 2018

justice_adams created D50563: Fixed frontend clang tests in windows read-only container.
Aug 10 2018, 8:51 AM · Restricted Project