- User Since
- Aug 9 2018, 5:42 PM (94 w, 4 d)
Mon, May 4
- Fix formatting
Sun, May 3
- Converted to range-based for loop
@rnk Thanks for the suggestions, I've updated it. If it looks good on your end, yes, I would appreciate it if you could commit this for me, I don't have commit access.
Apr 30 2020
Apr 29 2020
@rnk Sorry for the delay, I moved the file path length handling accordingly
- moved handling of long paths to createGraphFilename()
Apr 15 2020
So, if I want clang to overwrite some file, all I have to do is pass clang -mllvm -view-dag-combine1-dags and I can create a file with a name from the input source? That seems dangerous.
Apr 13 2020
Ping requesting review
Mar 26 2020
- removed static declaration from header file
- cleaned up code according to clang-tidy specifications
I've attached a reproducible.zip folder. To reproduce this bug, unzip the folder and compile multiply.cpp to LLVM IR and then run
Feb 24 2020
@RKSimon Thank you for the review, would you be able to commit this for me? I don't have commit access
Feb 19 2020
Jan 24 2020
Thank you for the review @spatel . I do not have commit access, could you possibly commit this for me?
Jan 23 2020
@RKSimon I removed the unnecessary braces. Good catch
@spatel My mistake! I have run clang-format on the patch and the diff should be cleaned up
Ran clang-format on the patch
Jan 16 2020
Oct 3 2019
@rupprecht Thanks for the explanation, that makes perfect sense. This LGTM (but note that I'm fairly new to the binutils)
Oct 2 2019
@rupprecht With most of the lit test adjustments here the only change was the ordering, which makes sense. Could you help me understand why the addition of the various [1-9] style regex expressions were also added to certain tests? Are those just ensuring more verbose matches with FileCheck?
Sep 29 2019
@rupprecht A bit of a beginner to LLVM, but why add the suppression for DynamicRelocations when --disassemble is provided?
Sep 12 2019
Thanks for the review all. I don't have commit access, @grimar could you commit this for me?
Sep 11 2019
@grimar my apologies. I reuploaded the patch with more context according to the documentation you linked! Also, made the changes suggested via the comments above
Sep 10 2019
Restored check-empty check as suggested by @ychen
Sep 9 2019
Relevant BugZilla Bug: https://bugs.llvm.org/show_bug.cgi?id=41830
Feb 1 2019
@thakis thanks for the review. I don't have commit access, would you mind committing this for me?
@stella.stamenova These are the changes from our previous discussion regarding the usage of %T
Jan 31 2019
Jan 24 2019
@stella.stamenova thanks for the review. I don't have commit access, would you mind committing this for me?
Jan 23 2019
@stella.stamenova Thanks for the input, what about now?
@stella.stamenova Good suggestion, I think you are right. I have updated the diff to use %t, that way any end-users can control the way their lit test work in a read-only mount by simply altering the test_exec_root in their config
Dec 13 2018
Dec 12 2018
@cfe-commits Re-pinging this group to request a review on this patch
Oct 22 2018
@cfe-commits ping requesting a review on this patch