This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objcopy][NFC] Propagate errors in removeSymbols/removeSectionReferences
ClosedPublic

Authored by rupprecht on Jan 31 2019, 1:44 PM.

Event Timeline

rupprecht created this revision.Jan 31 2019, 1:44 PM
jhenderson accepted this revision.Feb 1 2019, 1:55 AM

LGTM.

llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp
188–189

Is moving this out-of-line just a readability thing (it's fine if so)? Otherwise I'm missing why you're doing it (ditto below).

This revision is now accepted and ready to land.Feb 1 2019, 1:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2019, 1:55 AM
rupprecht marked 2 inline comments as done.Feb 1 2019, 6:52 AM
rupprecht added inline comments.
llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp
188–189

Yes, just seemed more readable this way.

This revision was automatically updated to reflect the committed changes.
rupprecht marked an inline comment as done.