Don't handle vector conditions.
I think this can be merged in the future with
fewerElementsVectorSelect, although this becomes slightly tricky with
a vector condition.
Paths
| Differential D57522
GlobalISel: Implement narrowScalar for select ClosedPublic Authored by arsenm on Jan 31 2019, 9:22 AM.
Details Summary Don't handle vector conditions. I think this can be merged in the future with
Diff Detail Event TimelineHerald added subscribers: Petar.Avramovic, kristof.beyls, rovka and 3 others. · View Herald TranscriptJan 31 2019, 9:22 AM This revision is now accepted and ready to land.Feb 4 2019, 3:21 PM arsenm added inline comments.
Revision Contents
Diff 184528 include/llvm/CodeGen/GlobalISel/LegalizerHelper.h
lib/CodeGen/GlobalISel/LegalizerHelper.cpp
test/CodeGen/AMDGPU/GlobalISel/legalize-select.mir
|
I think this should either be an assert or return UnableToLegalize and report a fallback.