Page MenuHomePhabricator

Add zlib feature to compiler-rt lit config
ClosedPublic

Authored by ormris on Mon, Jan 28, 5:24 PM.

Details

Summary

A new test was added to libfuzzer in r352265 that requires zlib. Our internal
buildbot doesn’t have zlib installed and other projects (llvm, clang) allow us
to add this as a “REQUIRES” flag. This change adds this flag to the compiler-rt
project.

Diff Detail

Repository
rL LLVM

Event Timeline

ormris created this revision.Mon, Jan 28, 5:24 PM
ormris updated this revision to Diff 183999.Mon, Jan 28, 5:30 PM

Move this change to the top level of compiler-rt lit config.

ormris retitled this revision from Add zlib feature to compiler-rt to Add zlib feature to compiler-rt lit config.Mon, Jan 28, 5:31 PM
ormris edited the summary of this revision. (Show Details)
ormris updated this revision to Diff 184000.Mon, Jan 28, 5:32 PM

Update again due to git confusion.

eugenis accepted this revision.Mon, Jan 28, 5:36 PM

LGTM

compiler-rt/test/lit.common.configured.in
49 ↗(On Diff #184000)

Use set_default for consistency. I doubt anything would want to override this setting, but still.

This revision is now accepted and ready to land.Mon, Jan 28, 5:36 PM
This revision was automatically updated to reflect the committed changes.