This is an archive of the discontinued LLVM Phabricator instance.

[scudo] Delay allocations in the RSS check test
ClosedPublic

Authored by cryptoad on Jan 25 2019, 8:32 AM.

Details

Summary

D57116 fails on the armv7 bots, which is I assume due to the timing of
the RSS check on the platform. While I don't have a platform to test
that change on, I assume this would do.

The test could be made more reliable by either delaying more the
allocations, or allocating more large-chunks, but both those options
have a somewhat non negligible impact (more memory used, longer test).

Hence me trying to keep the additional sleeping/allocating to a
minimum.

Diff Detail

Event Timeline

cryptoad created this revision.Jan 25 2019, 8:32 AM
yroux accepted this revision.Jan 25 2019, 9:14 AM

looks good to me, I'll keep an eye on the bots to check the fix. Thanks

This revision is now accepted and ready to land.Jan 25 2019, 9:14 AM
This revision was automatically updated to reflect the committed changes.