Page MenuHomePhabricator

[scudo] Tuning changes based on feedback from current use
ClosedPublic

Authored by cryptoad on Jan 23 2019, 12:56 PM.

Details

Summary

This tunes several of the default parameters used within the allocator:

  • disable the deallocation type mismatch on Android by default; this was causing too many issues with third party libraries;
  • change the default SizeClassMap to Dense, it caches less entries and is way more memory efficient overall;
  • relax the timing of the RSS checks, 10 times per second was too much, lower it to 4 times (every 250ms), and update the test so that it passes with the new default.

Diff Detail

Event Timeline

cryptoad created this revision.Jan 23 2019, 12:56 PM
Herald added subscribers: Restricted Project, delcypher, srhines. · View Herald TranscriptJan 23 2019, 12:56 PM
eugenis accepted this revision.Jan 23 2019, 1:15 PM

LGTM

This revision is now accepted and ready to land.Jan 23 2019, 1:15 PM
This revision was automatically updated to reflect the committed changes.