Page MenuHomePhabricator

[Fixed Point] [AST] Add an AST serialization code for fixed-point literals.
AcceptedPublic

Authored by ebevhan on Jan 25 2019, 3:39 AM.

Details

Summary

This patch adds the EXPR_FIXEDPOINT_LITERAL AST
code to serialize FixedPointLiterals. They were previously
being serialized with the code for integer literals, which
doesn't work properly.

Diff Detail

Event Timeline

ebevhan created this revision.Jan 25 2019, 3:39 AM
ebevhan marked an inline comment as done.Jan 25 2019, 3:41 AM
ebevhan added inline comments.
include/clang/Serialization/ASTBitCodes.h
1637

I'm unsure if this is the right location for a new code. This will bump down all the other codes below this and cause any older file to not be read correctly.

Should the file format version number be bumped up?

rjmccall added inline comments.Jan 25 2019, 9:27 AM
include/clang/Serialization/ASTBitCodes.h
1637

IIRC the real file format version for this is based on the exact revision of the compiler and there is no pretense of serialized ASTs being sharable between compilers. I don't think we've ever bumped the version number for incompatible changes like this.

leonardchan accepted this revision.Feb 21 2019, 3:19 PM

LGTM. Everything still seems to work on my end after applying this diff.

This revision is now accepted and ready to land.Feb 21 2019, 3:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2019, 3:19 PM
bjope added a subscriber: bjope.Oct 9 2019, 7:55 AM