This is an archive of the discontinued LLVM Phabricator instance.

Don't run misc-non-private-member-variables-in-classes check on LLVM.
Needs ReviewPublic

Authored by hokein on Jan 25 2019, 3:27 AM.

Details

Reviewers
alexfh
Summary

The check adds too much nosie on LLVM codebase (especially running clangd
with clang-tidy enabled).

The check seems too aggresive, it will give warnings as long as a struct
has a method, e.g.

struct Foo {

int X;
void f() {};

};

Diff Detail

Event Timeline

hokein created this revision.Jan 25 2019, 3:27 AM

it is very noisy (in other projects too) and i would prefer a different warning policy for that check as well (e.g. one warning per class, not for every field it warns against).