[libFuzzer][MSVC] Disable exceptions in MSVC headers

[metzman]

Summary

Disable exceptions in MSVC headers using -D_HAS_EXCEPTIONS=0
to silence compiler warning instead of using /Ehsc.

[metzman]

@rnk could you please take a look?

@morehouse are you OK with this change?

[rnk]

Hm, I can't find fno-exceptions anywhere in the libfuzzer cmake files, so I'm questioning my original assumption that this code is supposed to have exceptions disabled. If libfuzzer is supposed to have exceptions enabled, we should leave /EHsc in place as is.

[metzman]

In D57119#1368624, @rnk wrote:

Hm, I can't find fno-exceptions anywhere in the libfuzzer cmake files, so I'm questioning my original assumption that this code is supposed to have exceptions disabled. If libfuzzer is supposed to have exceptions enabled, we should leave /EHsc in place as is.

Maybe Matt knows the answer to this?
AFAIK though, libFuzzer doesn't use exceptions.
Would there be a reason to allow exceptions even though one isn't using them?

[morehouse]

libFuzzer doesn't disable exceptions itself, but the private libc++ it builds has exceptions disabled. So this should be fine for MSVC STL.

[metzman]

@rnk does this look good to land to you?

[rnk]

lgtm

[mstorsjo]

I'm a bit curious about the root causes of this patch - is it for builds with MS STL or libc++, and what were the actual issues it was trying to fix? I'm getting mixed signals from the comments in the discussion thread above.

As things stand right now, the -D_HAS_EXCEPTIONS=0 option breaks libc++ when it runs on top of vcruntime, see D103947 for a fix for that and for discussion whether this is a setup that libc++ wants to commit to supporting.

lib/fuzzer/CMakeLists.txt

 
 append_list_if(COMPILER_RT_HAS_OMIT_FRAME_POINTER_FLAG -fno-omit-frame-pointer LIBFUZZER_CFLAGS)
 
 if (CMAKE_CXX_FLAGS MATCHES "fsanitize-coverage")
   list(APPEND LIBFUZZER_CFLAGS -fno-sanitize-coverage=trace-pc-guard,edge,trace-cmp,indirect-calls,8bit-counters)
 endif()
 
 if(MSVC)
-  # Silence warnings with /Ehsc and avoid an error by unecessarily defining
-  # thread_local when it isn't even used on Windows.
-  list(APPEND LIBFUZZER_CFLAGS /EHsc)
+  # Silence warnings by turning off exceptions in MSVC headers and avoid an
+  # error by unecessarily defining thread_local when it isn't even used on
+  # Windows.
+  list(APPEND LIBFUZZER_CFLAGS -D_HAS_EXCEPTIONS=0)
 else()
   if(NOT HAS_THREAD_LOCAL)
     list(APPEND LIBFUZZER_CFLAGS -Dthread_local=__thread)
   endif()
 endif()
 
 set(FUZZER_SUPPORTED_OS ${SANITIZER_COMMON_SUPPORTED_OS})