This is an archive of the discontinued LLVM Phabricator instance.

Differential D57077

[clangd] Link clangTidy into clangd tests
ClosedPublic

Authored by nridge on Jan 22 2019, 6:50 PM.

Details

Reviewers
hokein
Commits
rG87b0e3fda998: [clangd] Link clangTidy into clangd tests
rCTE351929: [clangd] Link clangTidy into clangd tests
rL351929: [clangd] Link clangTidy into clangd tests

Diff Detail

Event Timeline

nridge created this revision.Jan 22 2019, 6:50 PM
Herald added subscribers: kadircet, arphaman, jkorous and 4 others. · View Herald TranscriptJan 22 2019, 6:50 PM
nridge added a comment.Jan 22 2019, 6:52 PM

After pulling the latest code, I found this change was necessary to get past the following linker error:

clang-tools-extra/unittests/clangd/TestTU.cpp:9443: error: undefined reference to 'clang::tidy::ClangTidyOptions::getDefaults()'

I assume this is a regression from https://reviews.llvm.org/D55256.

Harbormaster completed remote builds in B27183: Diff 183018.Jan 22 2019, 6:52 PM
hokein accepted this revision.Jan 23 2019, 12:00 AM

LGtM, thanks!

This revision is now accepted and ready to land.Jan 23 2019, 12:00 AM
Closed by commit rL351929: [clangd] Link clangTidy into clangd tests (authored by hokein). · Explain WhyJan 23 2019, 12:05 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 23 2019, 12:05 AM

Revision Contents

PathSize
clang-tools-extra/
unittests/
clangd/
1 line

Diff 183018

clang-tools-extra/unittests/clangd/CMakeLists.txt

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Linestarget_link_libraries(ClangdTests
clangBasic clangBasic
clangDaemon clangDaemon
clangFormat clangFormat
clangFrontend clangFrontend
clangIndex clangIndex
clangLex clangLex
clangSema clangSema
clangSerialization clangSerialization
clangTidy
clangTooling clangTooling
clangToolingCore clangToolingCore
clangToolingInclusions clangToolingInclusions
LLVMSupport LLVMSupport
LLVMTestingSupport LLVMTestingSupport
) )
if (CLANGD_BUILD_XPC) if (CLANGD_BUILD_XPC)
add_subdirectory(xpc) add_subdirectory(xpc)
endif () endif ()