This is an archive of the discontinued LLVM Phabricator instance.

[libcxxabi] Enable LLVM_ENABLE_WARNINGS when building standalone out of tree
ClosedPublic

Authored by mstorsjo on Jan 20 2019, 1:17 PM.

Diff Detail

Event Timeline

mstorsjo created this revision.Jan 20 2019, 1:17 PM
EricWF accepted this revision.Jan 20 2019, 10:14 PM

Does libc++ need a similar change?

This revision is now accepted and ready to land.Jan 20 2019, 10:14 PM

Does libc++ need a similar change?

No - for reasons I'm not familiar with entirely, libc++ doesn't include HandleLLVMOptions. The last commit where HandleLLVMOptions was included was SVN r243591 ("Attempt to fix build issues introduced by r243574"), while it was gone in SVN r243593 ("Revert recent CMake changes again due to failing compiler-rt builds"). However libunwind needs the same (D56981).

ldionne accepted this revision.Jan 22 2019, 6:43 AM
This revision was automatically updated to reflect the committed changes.