This is an archive of the discontinued LLVM Phabricator instance.

[libunwind] [SjLj] Don't use __declspec(thread) in MinGW mode
ClosedPublic

Authored by mstorsjo on Jan 18 2019, 5:24 AM.

Details

Summary

GCC and Clang in MinGW mode don't support __declspec(thread), which after expanding macros ends up as __attribute__((thread)). Use the GCC specific attribute __thread instead (the next one in the chain of alternatives).

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Jan 18 2019, 5:24 AM
mstorsjo edited the summary of this revision. (Show Details)Jan 18 2019, 5:25 AM
rnk accepted this revision.Jan 18 2019, 11:03 AM

lgtm

This revision is now accepted and ready to land.Jan 18 2019, 11:03 AM
mclow.lists accepted this revision.Jan 18 2019, 12:06 PM

Sigh. At least we've got a macro wrapping this; we only have to pore over this once.

This revision was automatically updated to reflect the committed changes.