This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Fix windows compiler warning by using explicit 64bit shift. NFC.
ClosedPublic

Authored by sbc100 on Jan 17 2019, 12:15 PM.

Reviewers

dschuff
msearles

Commits

Repository

rLLD LLVM Linker

Build Status

Buildable 27008
Build 27007: arc lint + arc unit

Would you kindly apply the same fix to:

lld/trunk/wasm/Writer.cpp:694 :
MemoryPtr = alignTo(MemoryPtr, 1 << Seg->Alignment);

1 -> 1ULL

LGTM

This revision is now accepted and ready to land.Jan 17 2019, 1:08 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

wasm/

2 lines

	Show All 20 Lines

	class OutputSegment {			class OutputSegment {
	public:			public:
	OutputSegment(StringRef N, uint32_t Index) : Name(N), Index(Index) {}			OutputSegment(StringRef N, uint32_t Index) : Name(N), Index(Index) {}

	void addInputSegment(InputSegment *InSeg) {			void addInputSegment(InputSegment *InSeg) {
	Alignment = std::max(Alignment, InSeg->getAlignment());			Alignment = std::max(Alignment, InSeg->getAlignment());
	InputSegments.push_back(InSeg);			InputSegments.push_back(InSeg);
	Size = llvm::alignTo(Size, 1 << InSeg->getAlignment());			Size = llvm::alignTo(Size, 1ULL << InSeg->getAlignment());
	InSeg->OutputSeg = this;			InSeg->OutputSeg = this;
	InSeg->OutputSegmentOffset = Size;			InSeg->OutputSegmentOffset = Size;
	Size += InSeg->getSize();			Size += InSeg->getSize();
	}			}

	StringRef Name;			StringRef Name;
	const uint32_t Index;			const uint32_t Index;
	uint32_t SectionOffset = 0;			uint32_t SectionOffset = 0;
	Show All 15 Lines