[analyzer] MoveChecker: add ".assign" to the list of common reinitializing methods.

[NoQ]

Summary

Eg., std::vector<T>::assign(std::initializer_list<T>).

I wonder how many more did we miss.

[baloghadamsoftware]

I think it is straightforward. Thank you for noticing this.

lib/StaticAnalyzer/Checkers/MoveChecker.cpp

bool MoveChecker::isStateResetMethod(const CXXMethodDecl *MethodDec) const {
   if (!MethodDec)
       return false;
   if (MethodDec->hasAttr<ReinitializesAttr>())
       return true;
   if (MethodDec->getDeclName().isIdentifier()) {
     std::string MethodName = MethodDec->getName().lower();
     // TODO: Some of these methods (eg., resize) are not always resetting
     // the state, so we should consider looking at the arguments.
-    if (MethodName == "reset" || MethodName == "clear" ||
-        MethodName == "destroy" || MethodName == "resize" ||
-        MethodName == "shrink")
+    if (MethodName == "assign" || MethodName == "clear" ||
+        MethodName == "destroy" || MethodName == "reset" ||
+        MethodName == "resize" || MethodName == "shrink")
       return true;
   }
   return false;
 }
 
 // Don't report an error inside a move related operation.
 // We assume that the programmer knows what she does.
 bool MoveChecker::isInMoveSafeContext(const LocationContext *LC) const {

test/Analysis/use-after-move.cpp

#endif
   }
   int getI() { return i; }
   int foo() const;
   void bar() const;
   void reset();
   void destroy();
   void clear();
   void resize(std::size_t);
+  void assign(const A &);
   bool empty() const;
   bool isEmpty() const;
   operator bool() const;
 
   void testUpdateField() {
     A a;
     A b = std::move(a);
     a.i = 1;
void moveStateResetFunctionsTest() {
   }
   {
     A a;
     A b = std::move(a);
     a.resize(0); // no-warning
     a.foo();   // no-warning
     a.b.foo(); // no-warning
   }
+  {
+    A a;
+    A b = std::move(a);
+    a.assign(A()); // no-warning
+    a.foo();   // no-warning
+    a.b.foo(); // no-warning
+  }
 }
 
 // Moves or uses that occur as part of template arguments.
 template <int>
 class ClassTemplate {
 public:
   void foo(A a);
 };