This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Merge producers section
ClosedPublic

Authored by tlively on Jan 16 2019, 1:52 PM.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

tlively created this revision.Jan 16 2019, 1:52 PM

This has a cyclic dependency on D56742, but phabricator won't let me express that.

tlively updated this revision to Diff 182166.Jan 16 2019, 3:19 PM
  • Change to getProducerInfo interface
sbc100 accepted this revision.Jan 16 2019, 3:29 PM
sbc100 added inline comments.
wasm/Writer.cpp
654

From brazed from these two single line blocks. That the lld style anyway.

657

Call this FieldCount ?

815–816

Add another newline here for visual consistency?

This revision is now accepted and ready to land.Jan 16 2019, 3:29 PM
tlively updated this revision to Diff 182176.Jan 16 2019, 3:47 PM
tlively marked 3 inline comments as done.
  • Style fixes
This revision was automatically updated to reflect the committed changes.