Page MenuHomePhabricator

Change TypeSystem::GetBitSize() to return an optional result.
ClosedPublic

Authored by aprantl on Jan 16 2019, 11:08 AM.

Details

Summary

This patch changes the behavior when printing C++ function references: where we previously would get a <could not determine size>, there is now a <no summary available>. It's not clear to me whether this is a bug or an omission, but it's one step further than LLDB previously got.

Diff Detail

Repository
rL LLVM

Event Timeline

aprantl created this revision.Jan 16 2019, 11:08 AM
labath accepted this revision.Jan 16 2019, 12:27 PM

The new "error" message definitely makes more sense. The rest of the patch seems fine too.

This revision is now accepted and ready to land.Jan 16 2019, 12:27 PM
This revision was automatically updated to reflect the committed changes.