Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Looks good to me with a minor comment fix. Let's wait for @efriedma to approve the new name before we commit to it, though.
include/llvm/IR/Intrinsics.td | ||
---|---|---|
418–419 | Hm, this comment was already stale. I'd update it to something like, "Given the frame pointer passed into an SEH filter function, returns a pointer to the local variable area suitable for use with llvm.localrecover". |
llvm/trunk/lib/IR/AutoUpgrade.cpp | ||
---|---|---|
547 ↗ | (On Diff #181930) | This is under switch (Name[0]) { case 'a': -- so x86 will never match here. |
llvm/trunk/lib/IR/AutoUpgrade.cpp | ||
---|---|---|
547 ↗ | (On Diff #181930) | This is fixed in https://reviews.llvm.org/D57614. |
Hm, this comment was already stale. I'd update it to something like, "Given the frame pointer passed into an SEH filter function, returns a pointer to the local variable area suitable for use with llvm.localrecover".