This is an archive of the discontinued LLVM Phabricator instance.

[EH] Rename llvm.x86.seh.recoverfp intrinsic to llvm.eh.recoverfp
ClosedPublic

Authored by mgrang on Jan 15 2019, 3:19 PM.

Details

Summary

Make recoverfp intrinsic target-independent so that it can be implemented for AArch64, etc.
Refer D53541 for the context. Clang counterpart D56748.

Diff Detail

Event Timeline

mgrang created this revision.Jan 15 2019, 3:19 PM
rnk accepted this revision.Jan 15 2019, 3:30 PM

Looks good to me with a minor comment fix. Let's wait for @efriedma to approve the new name before we commit to it, though.

include/llvm/IR/Intrinsics.td
418–419

Hm, this comment was already stale. I'd update it to something like, "Given the frame pointer passed into an SEH filter function, returns a pointer to the local variable area suitable for use with llvm.localrecover".

This revision is now accepted and ready to land.Jan 15 2019, 3:30 PM
mgrang updated this revision to Diff 181906.Jan 15 2019, 3:41 PM
mgrang marked an inline comment as done.
mgrang updated this revision to Diff 181917.Jan 15 2019, 4:08 PM

Rebased.

efriedma accepted this revision.Jan 15 2019, 4:16 PM

New name seems fine; LGTM

efriedma requested changes to this revision.Jan 15 2019, 4:17 PM

Err, sorry, hang on, missing change for lib/IR/AutoUpgrade.cpp?

This revision now requires changes to proceed.Jan 15 2019, 4:17 PM
mgrang updated this revision to Diff 181927.Jan 15 2019, 4:33 PM
This revision is now accepted and ready to land.Jan 15 2019, 4:35 PM
This revision was automatically updated to reflect the committed changes.
cuviper added inline comments.
llvm/trunk/lib/IR/AutoUpgrade.cpp
547 ↗(On Diff #181930)

This is under switch (Name[0]) { case 'a': -- so x86 will never match here.

mgrang marked an inline comment as done.Jan 15 2019, 5:15 PM
mgrang added inline comments.
llvm/trunk/lib/IR/AutoUpgrade.cpp
547 ↗(On Diff #181930)

Thanks @cuviper. Will fix this.

mgrang marked an inline comment as done.Feb 1 2019, 12:38 PM
mgrang added inline comments.
llvm/trunk/lib/IR/AutoUpgrade.cpp
547 ↗(On Diff #181930)
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2019, 12:38 PM