- User Since
- Jul 30 2018, 2:40 PM (63 w, 4 d)
Sep 5 2019
Apr 23 2019
Ping for review, please.
Apr 3 2019
Jan 22 2019
I'll have to review that discussion of this pointers wrt Rust, since self can be different things, but it hasn't caused us problems yet AFAIK.
FWIW, here's more context for how I arrived at this:
Jan 15 2019
Sep 13 2018
Sep 11 2018
I don't think you need approval from all reviewers, as long as nobody actively disagrees. But FWIW, it looks good to me too.
Sep 7 2018
- Removed the duplicate (and incorrect) declaration in debug-insts.ll debug_declare
- Added debug-cpp.ll which more directly targets this change.
Sep 6 2018
Aug 1 2018
Superseded by D50096.
Jul 31 2018
D50018 was spurred by failures in the Rust testsuite, and I've confirmed this patch also resolves those failures. Thanks!
Jul 30 2018
To be clear, this function actually combines SHL, SRA, SRL, and ROTL, so they should all be addressed accordingly. I only called out SHL because this was the particular one that bit me.