Page MenuHomePhabricator

cuviper (Josh Stone)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 30 2018, 2:40 PM (50 w, 5 d)

Recent Activity

Apr 23 2019

cuviper committed rG27924c3a3c67: [Lint] Permit aliasing noalias readonly arguments (authored by cuviper).
[Lint] Permit aliasing noalias readonly arguments
Apr 23 2019, 4:42 PM
cuviper committed rL359047: [Lint] Permit aliasing noalias readonly arguments.
[Lint] Permit aliasing noalias readonly arguments
Apr 23 2019, 4:42 PM
cuviper closed D60239: [Lint] Permit aliasing noalias readonly arguments.
Apr 23 2019, 4:42 PM · Restricted Project
cuviper added a comment to D60239: [Lint] Permit aliasing noalias readonly arguments.

Ping for review, please.

Apr 23 2019, 11:29 AM · Restricted Project

Apr 3 2019

cuviper created D60239: [Lint] Permit aliasing noalias readonly arguments.
Apr 3 2019, 4:19 PM · Restricted Project

Jan 22 2019

cuviper added a comment to D57070: [CodeView] Allow empty types in member functions.

I'll have to review that discussion of this pointers wrt Rust, since self can be different things, but it hasn't caused us problems yet AFAIK.

Jan 22 2019, 4:58 PM
cuviper committed rL351910: [CodeView] Allow empty types in member functions.
[CodeView] Allow empty types in member functions
Jan 22 2019, 4:54 PM
cuviper closed D57070: [CodeView] Allow empty types in member functions.
Jan 22 2019, 4:54 PM
cuviper added a comment to D57070: [CodeView] Allow empty types in member functions.

FWIW, here's more context for how I arrived at this:
https://github.com/rust-lang/rust/pull/57675#issuecomment-456210064

Jan 22 2019, 3:41 PM
cuviper created D57070: [CodeView] Allow empty types in member functions.
Jan 22 2019, 3:41 PM

Jan 15 2019

cuviper added inline comments to D56747: [EH] Rename llvm.x86.seh.recoverfp intrinsic to llvm.eh.recoverfp.
Jan 15 2019, 5:10 PM · Restricted Project

Sep 13 2018

cuviper added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

@glaubitz, I was specifically wondering if the author, @LionNatsu, would like to commit this on their own. I'm even more hesitant to intrude on your other review, where I wasn't involved at all.

Sep 13 2018, 12:18 PM
cuviper added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

Thank you all very much. It seems all reviewers have now approved the revision. When will it be landed, just by the way? Did it miss the merge window (if there is one)? 😄

Sep 13 2018, 11:40 AM

Sep 11 2018

cuviper committed rL341969: [GlobalISel] Lower dbg.declare into indirect DBG_VALUE.
[GlobalISel] Lower dbg.declare into indirect DBG_VALUE
Sep 11 2018, 10:57 AM
cuviper closed D51749: [GlobalISel] Lower dbg.declare into indirect DBG_VALUE.
Sep 11 2018, 10:57 AM
cuviper committed rL341966: Test commit: remove trailing whitespace.
Test commit: remove trailing whitespace
Sep 11 2018, 10:31 AM
cuviper added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

I don't think you need approval from all reviewers, as long as nobody actively disagrees. But FWIW, it looks good to me too.

Sep 11 2018, 9:22 AM

Sep 7 2018

cuviper updated the diff for D51749: [GlobalISel] Lower dbg.declare into indirect DBG_VALUE.
  • Removed the duplicate (and incorrect) declaration in debug-insts.ll debug_declare
  • Added debug-cpp.ll which more directly targets this change.
Sep 7 2018, 12:11 PM
cuviper added a comment to D51749: [GlobalISel] Lower dbg.declare into indirect DBG_VALUE.
In D51749#1226417, @rnk wrote:

I think this change could use a more direct test, consider starting with the IR generated for a C++ object, like:

struct NTCopy {
  NTCopy();
  NTCopy(const NTCopy &);
  int x;
};
int foo(NTCopy o) {
  return o.x;
}
Sep 7 2018, 11:39 AM

Sep 6 2018

cuviper updated the summary of D51749: [GlobalISel] Lower dbg.declare into indirect DBG_VALUE.
Sep 6 2018, 1:36 PM
cuviper created D51749: [GlobalISel] Lower dbg.declare into indirect DBG_VALUE.
Sep 6 2018, 1:32 PM

Aug 1 2018

cuviper abandoned D50018: SystemZ: keep AND masks before SHL i128.

Superseded by D50096.

Aug 1 2018, 11:42 AM

Jul 31 2018

cuviper added a comment to D50096: [SystemZ, TableGen] Fix shift count handling.

D50018 was spurred by failures in the Rust testsuite, and I've confirmed this patch also resolves those failures. Thanks!

Jul 31 2018, 4:45 PM

Jul 30 2018

cuviper added a comment to D50018: SystemZ: keep AND masks before SHL i128.

To be clear, this function actually combines SHL, SRA, SRL, and ROTL, so they should all be addressed accordingly. I only called out SHL because this was the particular one that bit me.

Jul 30 2018, 3:43 PM
cuviper created D50018: SystemZ: keep AND masks before SHL i128.
Jul 30 2018, 3:00 PM