This is an archive of the discontinued LLVM Phabricator instance.

Differential D56384

[AArch64] Add 'apple-latest' CPU alias
ClosedPublic

Authored by thegameg on Jan 7 2019, 4:01 AM.

Details

Reviewers
ab
t.p.northover
Gerolf
jasonmolenda
fhahn
Commits
rG556ea7d2e0ba: [AArch64] Add 'apple-latest' CPU alias
rL352412: [AArch64] Add 'apple-latest' CPU alias
Summary

The 'apple-latest' alias is supposed to provide a CPU that contains the latest Apple processor model supported by LLVM.

This is supposed to be used by tools like lldb to provide a target that supports most of the CPU features.

For now, this is mapped to Cyclone.

Diff Detail

Event Timeline

thegameg created this revision.Jan 7 2019, 4:01 AM
Herald added subscribers: kristof.beyls, javed.absar. · View Herald TranscriptJan 7 2019, 4:01 AM
thegameg updated this revision to Diff 180498.Jan 7 2019, 7:48 AM

Fix RUN command in test.

thegameg added a comment.Jan 17 2019, 7:08 AM

Ping?

thegameg added a comment.Jan 28 2019, 8:26 AM

Ping?

fhahn accepted this revision.Jan 28 2019, 9:21 AM
fhahn added a subscriber: fhahn.

LGTM. It might be worth to add the CPU to test/CodeGen/AArch64/cpus.ll as well.

This revision is now accepted and ready to land.Jan 28 2019, 9:21 AM
Closed by commit rL352412: [AArch64] Add 'apple-latest' CPU alias (authored by thegameg). · Explain WhyJan 28 2019, 11:27 AM
This revision was automatically updated to reflect the committed changes.
thegameg added a comment.Jan 28 2019, 1:46 PM

Thanks @fhahn!

Revision Contents

PathSize
lib/
Target/
AArch64/
3 lines
test/
CodeGen/
AArch64/
7 lines

Diff 180498

lib/Target/AArch64/AArch64.td

Show First 20 Lines • Show All 685 Lines • ▼ Show 20 Lines
def : ProcessorModel<"thunderxt88", ThunderXT8XModel, [ProcThunderXT88]>; def : ProcessorModel<"thunderxt88", ThunderXT8XModel, [ProcThunderXT88]>;
def : ProcessorModel<"thunderxt81", ThunderXT8XModel, [ProcThunderXT81]>; def : ProcessorModel<"thunderxt81", ThunderXT8XModel, [ProcThunderXT81]>;
def : ProcessorModel<"thunderxt83", ThunderXT8XModel, [ProcThunderXT83]>; def : ProcessorModel<"thunderxt83", ThunderXT8XModel, [ProcThunderXT83]>;
// Cavium ThunderX2T9X Processors. Formerly Broadcom Vulcan. // Cavium ThunderX2T9X Processors. Formerly Broadcom Vulcan.
def : ProcessorModel<"thunderx2t99", ThunderX2T99Model, [ProcThunderX2T99]>; def : ProcessorModel<"thunderx2t99", ThunderX2T99Model, [ProcThunderX2T99]>;
// FIXME: HiSilicon TSV110 is currently modeled as a Cortex-A57. // FIXME: HiSilicon TSV110 is currently modeled as a Cortex-A57.
def : ProcessorModel<"tsv110", CortexA57Model, [ProcTSV110]>; def : ProcessorModel<"tsv110", CortexA57Model, [ProcTSV110]>;
// Alias for the latest Apple processor model supported by LLVM.
def : ProcessorModel<"apple-latest", CycloneModel, [ProcCyclone]>;
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Assembly parser // Assembly parser
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
def GenericAsmParserVariant : AsmParserVariant { def GenericAsmParserVariant : AsmParserVariant {
int Variant = 0; int Variant = 0;
string Name = "generic"; string Name = "generic";
string BreakCharacters = "."; string BreakCharacters = ".";
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines

test/CodeGen/AArch64/apple-latest-cpu.ll

  • This file was added.
; RUN: llc -mtriple=arm64-apple-ios -mcpu=apple-latest -stop-before=expand-isel-pseudos -o - 2>&1 < %s | FileCheck %s
; CHECK-LABEL: @dummy
; CHECK: "target-cpu"="apple-latest"
define void @dummy() {
ret void
}