This is an archive of the discontinued LLVM Phabricator instance.

GlobalISel: Implement widen for extract_vector_elt elt type
ClosedPublic

Authored by arsenm on Jan 4 2019, 12:01 AM.

Diff Detail

Event Timeline

arsenm created this revision.Jan 4 2019, 12:01 AM
aemerson added inline comments.Jan 7 2019, 1:15 PM
test/CodeGen/AMDGPU/GlobalISel/legalize-extract-vector-elt.mir
261

What are these comments for?

arsenm marked an inline comment as done.Jan 7 2019, 5:09 PM
arsenm added inline comments.
test/CodeGen/AMDGPU/GlobalISel/legalize-extract-vector-elt.mir
261

These are cases that should be tested, but are broken for other reasons. I can remove them

arsenm updated this revision to Diff 180791.Jan 8 2019, 10:50 PM

Remove commented out test cases

aemerson accepted this revision.Jan 10 2019, 1:39 PM

LGTM.

This revision is now accepted and ready to land.Jan 10 2019, 1:39 PM
arsenm closed this revision.Jan 22 2019, 12:38 PM

r351871