This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Fix assert from machine verify pass that atomic pseudo expanding causes mismatched register class
ClosedPublic

Authored by wuzish on Dec 25 2018, 6:29 PM.

Details

Summary

For atomic value operand which less than 4 bytes need to be masked.
And the related operation to calculate the newvalue can be done in 32 bit gprc.
So just use gprc for mask and value calculation.

Diff Detail

Event Timeline

wuzish created this revision.Dec 25 2018, 6:29 PM
hfinkel accepted this revision.Dec 27 2018, 9:07 AM

Please fixup the comments, but LGTM.

llvm/lib/Target/PowerPC/PPCISelLowering.cpp
9982

This comment is wrapped oddly (you can go out to 80 characters), please rewrap. Also, it should end with a period.

10775

Same as above.

This revision is now accepted and ready to land.Dec 27 2018, 9:07 AM

Address comment from reviewer.

wuzish marked 2 inline comments as done.Dec 27 2018, 5:45 PM

The patch is out-of-date of trunk. Rebase to trunk.

This revision was automatically updated to reflect the committed changes.